Instead of tailored configuration files to look for module_path entries.
Reported by: kevans@
Details
Details
- Reviewers
kevans zlei - Commits
- rGd3b6d70e0dfa: freebsd-update(8): Use kern.module_path
Just try freebsd-update fetch upgrade
(yes, without the -r so the process will abort after the information message)
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 57168 Build 54056: arc lint + arc unit
Event Timeline
| usr.sbin/freebsd-update/freebsd-update.sh | ||
|---|---|---|
| 677 | The following is from x86_64 QEMU VM: # sysctl kern.module_path | cut -f2 -d\" | tr ";" "|" /boot/kernel|/boot/modules|/boot/dtb|/boot/dtb/overlays IIUC, 3rd party modules are not going to be installed into /boot/kernel . I'm not familiar with dtb parts, but I'd ask for confirmation if 3rd party modules will be installed into /boot/dtb or `/boot/dtb/overlays' ? | |
| usr.sbin/freebsd-update/freebsd-update.sh | ||
|---|---|---|
| 677 | Likely not, but if they are then the same caveat applies -- the kernel and dtb are generally pretty closely coupled, and there's some risk if you end up upgrading one without the other. Also, the cut step of the pipe can go away; use sysctl -n kern.module_path to omit the sysctl name and just get the value | |
| 679–680 | ||
| usr.sbin/freebsd-update/freebsd-update.sh | ||
|---|---|---|
| 677 |
Looks sane :)
| |
| usr.sbin/freebsd-update/freebsd-update.sh | ||
|---|---|---|
| 679–680 | Why? An empty sysctl is likely wrong, but loader.conf doesn't need any notion of a default because /boot/loader should always be passing it into the kernel for it to set it... | |
| usr.sbin/freebsd-update/freebsd-update.sh | ||
|---|---|---|
| 680–682 | An empty kern.module_path should not happen. So does it ( an empty kern.module_path ) deserve an informative message ? Just in case ... | |