Differential D44809

install: Remove the mmap(2) option.
ClosedPublic
Actions

Authored by des on Apr 16 2024, 4:34 PM.

Details

Reviewers

markj

Group Reviewers

Klara

Commits

rGa0439a1b820f: install: Remove the mmap(2) option.

Summary

We already removed it from cp(1) over a year ago but never followed up
here. Do so now, for the same reasons: significant complexity for
little to no benefit.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57126
Build 54014: arc lint + arc unit

Event Timeline

des created this revision.Apr 16 2024, 4:34 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 16 2024, 4:34 PM

des requested review of this revision.Apr 16 2024, 4:34 PM

Harbormaster completed remote builds in B57126: Diff 137109.Apr 16 2024, 4:34 PM

des added a child revision: D44810: install: Assorted nitpickery..Apr 16 2024, 4:34 PM

markj accepted this revision as: markj.Apr 16 2024, 7:09 PM

This revision is now accepted and ready to land.Apr 16 2024, 7:09 PM

Closed by commit rGa0439a1b820f: install: Remove the mmap(2) option. (authored by des). · Explain WhyApr 17 2024, 2:06 AM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGa0439a1b820f: install: Remove the mmap(2) option..

des mentioned this in rG34ee703400c0: install: Always use a temporary file..Apr 24 2024, 10:13 PM

des mentioned this in rG44101eb5803e: install: Always use a temporary file..Apr 27 2024, 2:59 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

xinstall/

install.1

3 lines

xinstall.c

211 lines

Diff 137109

View Options

usr.bin/xinstall/install.1