Page MenuHomeFreeBSD

install: Don't skip syncing in the common case.
ClosedPublic

Authored by des on Apr 12 2024, 2:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 13, 12:49 AM
Unknown Object (File)
Sat, Sep 12, 1:39 PM
Unknown Object (File)
Tue, Sep 8, 2:20 AM
Unknown Object (File)
Sun, Sep 6, 3:34 AM
Unknown Object (File)
Sun, Sep 6, 3:24 AM
Unknown Object (File)
Sat, Sep 5, 10:24 AM
Unknown Object (File)
Sat, Sep 5, 5:57 AM
Unknown Object (File)
Thu, Sep 3, 7:24 AM
Subscribers

Details

Summary

In copy(), if no digest was requested (which is the common case), we
use copy_file_range() to avoid needlessly copying the contents of the
file into user space and back. When copy_file_range() returns
successfully (which, again, is the common case), we simply return, and
therefore never get to the point where we call fsync() if the -S
option was specified. Fix this.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57053
Build 53941: arc lint + arc unit