Page MenuHomeFreeBSD

install: Don't skip syncing in the common case.
ClosedPublic

Authored by des on Apr 12 2024, 2:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 29, 2:20 PM
Unknown Object (File)
Jul 3 2026, 5:38 AM
Unknown Object (File)
Jul 3 2026, 12:15 AM
Unknown Object (File)
Jul 2 2026, 7:38 PM
Unknown Object (File)
Jul 2 2026, 1:51 PM
Unknown Object (File)
Jun 27 2026, 1:50 AM
Unknown Object (File)
May 17 2026, 11:29 PM
Unknown Object (File)
May 17 2026, 11:29 PM
Subscribers

Details

Summary

In copy(), if no digest was requested (which is the common case), we
use copy_file_range() to avoid needlessly copying the contents of the
file into user space and back. When copy_file_range() returns
successfully (which, again, is the common case), we simply return, and
therefore never get to the point where we call fsync() if the -S
option was specified. Fix this.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable