Page MenuHomeFreeBSD

install: Don't skip syncing in the common case.
ClosedPublic

Authored by des on Apr 12 2024, 2:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 3:02 AM
Unknown Object (File)
Sun, Oct 12, 9:30 AM
Unknown Object (File)
Sun, Oct 12, 9:30 AM
Unknown Object (File)
Sun, Oct 12, 9:30 AM
Unknown Object (File)
Sat, Oct 11, 10:39 PM
Unknown Object (File)
Sun, Sep 28, 1:57 AM
Unknown Object (File)
Sep 12 2025, 11:48 AM
Unknown Object (File)
Sep 9 2025, 7:43 PM
Subscribers

Details

Summary

In copy(), if no digest was requested (which is the common case), we
use copy_file_range() to avoid needlessly copying the contents of the
file into user space and back. When copy_file_range() returns
successfully (which, again, is the common case), we simply return, and
therefore never get to the point where we call fsync() if the -S
option was specified. Fix this.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable