MFC after: 1 week
Obtained from: NetBSD
Sponsored by: Klara, Inc.
Details
Details
- Reviewers
imp cperciva - Group Reviewers
Klara - Commits
- rG43e0ae562921: sys/queue.h: Add {LIST,TAILQ}_REPLACE().
rG7f479dee4897: sys/queue.h: Add {LIST,TAILQ}_REPLACE().
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 56960 Build 53848: arc lint + arc unit
Event Timeline
Comment Actions
Seems OK to me: doesn't make things worse, provides a good function not. yet available, and is compatible with at least one other system.
| share/man/man3/queue.3 | ||
|---|---|---|
| 975 | If I were writing this myself, I would add "The element .Fa new must not already be on a list." for clarity, but it's probably not worth diverging from NetBSD. | |
| sys/sys/queue.h | ||
| 883 | I would have written this as (elm2)->field.tqe_next = (elm)->field.tqe_next;
if ((elm2)->field.tqe_next != TAILQ_END(head))
....since I think that's a bit clearer with all the added parentheses associated with macros, but this is also fine. | |
Comment Actions
I don't mind diverging from NetBSD if it's an improvement, we've already diverged quite a bit.
| sys/sys/queue.h | ||
|---|---|---|
| 620 | This could be s/elm/elm2/ but since they're equal at this point it doesn't matter. | |