sound: Get rid of pcm/sndstat.h and turn macros into regular code
ClosedPublic
Actions

Authored by christos on Mar 28 2024, 8:33 AM.

Details

Reviewers

markj
dev_submerge.ch

Commits

rG4dfb88f3dea5: sound: Get rid of pcm/sndstat.h and turn macros into regular code
rG6d1cee1640e1: sound: Get rid of pcm/sndstat.h and turn macros into regular code

Summary

There is no reason to have macros for this. Putting the code in
sndstat_prepare_pcm() directly makes it easier to work with it.

No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56820
Build 53708: arc lint + arc unit

Event Timeline

christos created this revision.Mar 28 2024, 8:33 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 28 2024, 8:33 AM

christos requested review of this revision.Mar 28 2024, 8:33 AM

Harbormaster completed remote builds in B56819: Diff 136300.Mar 28 2024, 8:33 AM

Diff against main.

Harbormaster completed remote builds in B56820: Diff 136301.Mar 28 2024, 8:37 AM

christos added a child revision: D44546: sound: Make verbose sndstat output more readable.Mar 28 2024, 11:08 AM

Seems reasonable.

This revision is now accepted and ready to land.Mar 29 2024, 2:16 PM

Closed by commit rG6d1cee1640e1: sound: Get rid of pcm/sndstat.h and turn macros into regular code (authored by christos). · Explain WhyMar 29 2024, 3:33 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG6d1cee1640e1: sound: Get rid of pcm/sndstat.h and turn macros into regular code.

christos added a commit: rG4dfb88f3dea5: sound: Get rid of pcm/sndstat.h and turn macros into regular code.Apr 12 2024, 1:13 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

sndstat.h

sound.c

136 lines

Diff 136301

View Options

sys/dev/sound/pcm/sndstat.h