Page MenuHomeFreeBSD
Differential D44544

sound: Drain buffer selinfo in sndbuf_free()
ClosedPublic
Actions

Authored by christos on Mar 28 2024, 5:15 AM.
Tags
None
Referenced Files
F167861095: D44544.id136327.diff
Tue, Aug 25, 1:49 AM
F167831503: D44544.diff
Mon, Aug 24, 8:36 PM
Unknown Object (File)
Sun, Aug 23, 12:12 AM
Unknown Object (File)
Thu, Aug 20, 12:22 PM
Unknown Object (File)
Thu, Aug 13, 2:32 PM
Unknown Object (File)
Wed, Aug 12, 12:25 PM
Unknown Object (File)
Wed, Aug 12, 10:41 AM
Unknown Object (File)
Wed, Aug 12, 12:17 AM
View All Files
Subscribers
None

Details

Reviewers
markj
emaste
dev_submerge.ch
imp
Commits
rGea2275e72cda: sound: Drain buffer selinfo in sndbuf_free()
rGfba54d0179aa: sound: Drain buffer selinfo in sndbuf_free()
Summary

Prevent a use-after-free in kern_poll() by making sure the buffer's
selinfo is drained.

Reported by: KASAN
Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56818
Build 53706: arc lint + arc unit

Event Timeline

christos requested review of this revision.Mar 28 2024, 5:15 AM
christos created this revision.
Harbormaster completed remote builds in B56818: Diff 136299.Mar 28 2024, 5:15 AM
christos mentioned this in D43545: sound: Implement asynchronous device detach.Mar 28 2024, 5:16 AM
christos added a child revision: D43545: sound: Implement asynchronous device detach.
christos retitled this revision from sound: drain buffer selinfo during sndbuf_free() to sound: Drain buffer selinfo in sndbuf_free().Mar 28 2024, 5:18 AM
markj accepted this revision.Mar 29 2024, 2:43 PM

In the commit message, you should note that this is only required with async detach.

This revision is now accepted and ready to land.Mar 29 2024, 2:43 PM
Closed by commit rGfba54d0179aa: sound: Drain buffer selinfo in sndbuf_free() (authored by christos). · Explain WhyMar 29 2024, 3:33 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGfba54d0179aa: sound: Drain buffer selinfo in sndbuf_free().
christos removed a child revision: D43545: sound: Implement asynchronous device detach.Apr 11 2024, 4:13 PM
christos added a commit: rGea2275e72cda: sound: Drain buffer selinfo in sndbuf_free().Apr 12 2024, 1:13 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
1 line

Diff 136299

View Options

sys/dev/sound/pcm/buffer.c

Loading...