Page MenuHomeFreeBSD
Differential D44521

hvsock: make pcb declaration private
Needs ReviewPublic
Actions

Authored by freebsd_igalic.co on Mar 26 2024, 10:33 PM.
Tags
None
Referenced Files
F106199074: D44521.diff
Fri, Dec 27, 1:00 AM
Unknown Object (File)
Nov 24 2024, 11:32 PM
Unknown Object (File)
Nov 14 2024, 11:50 AM
Unknown Object (File)
Nov 10 2024, 2:50 AM
Unknown Object (File)
Nov 7 2024, 2:11 PM
Unknown Object (File)
Oct 26 2024, 4:27 PM
Unknown Object (File)
Oct 25 2024, 6:42 PM
Unknown Object (File)
Oct 1 2024, 8:06 PM
View All 31 Files
Subscribers
glebius
imp
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This shouldn't be public. Even tho this header file is not public API,
move the pcb declaration to the C file.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56799
Build 53687: arc lint + arc unit

Event Timeline

freebsd_igalic.co created this revision.Mar 26 2024, 10:33 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 26 2024, 10:33 PM
freebsd_igalic.co requested review of this revision.Mar 26 2024, 10:33 PM
Harbormaster completed remote builds in B56799: Diff 136243.Mar 26 2024, 10:33 PM
freebsd_igalic.co added a parent revision: D44520: hvsock: remove useless casts, checks & functions.Mar 26 2024, 10:34 PM
glebius added a subscriber: glebius.Mar 27 2024, 12:08 AM
glebius added inline comments.
sys/dev/hyperv/hvsock/hv_sock.h
33

I'm pretty sure now these three includes can go away. At least socketvar.h and queue.h can. Ideally socket.h should go away, too, and users who get sockaddr definition via hv_sock.h need to be fixed.

he world build needs to be tested of course, don't trust my word :)

Revision Contents
Changeset List

PathSize
sys/
dev/
hyperv/
hvsock/
21 lines
21 lines

Diff 136243

View Options

sys/dev/hyperv/hvsock/hv_sock.h

Loading...
View Options

sys/dev/hyperv/hvsock/hv_sock.c

Loading...