Page MenuHomeFreeBSD
Differential D44503

libc: Improve description of mktime() / timegm().
ClosedPublic
Actions

Authored by des on Mar 26 2024, 3:37 AM.
Tags
None
Referenced Files
F159545777: D44503.diff
Mon, Jun 15, 2:20 PM
F159543958: D44503.id136210.diff
Mon, Jun 15, 1:56 PM
F159543957: D44503.id136210.diff
Mon, Jun 15, 1:56 PM
F159543797: D44503.id136257.diff
Mon, Jun 15, 1:55 PM
Unknown Object (File)
Tue, May 19, 9:32 AM
Unknown Object (File)
Sun, May 17, 11:37 PM
Unknown Object (File)
Sun, May 17, 11:37 PM
Unknown Object (File)
Sun, May 17, 11:17 PM
View All Files
Subscribers
gbe
imp
pauamma_chezdork.com

Details

Reviewers
pauamma_chezdork.com
gbe
Group Reviewers
manpages
Commits
rGfdde01c5b449: libc: Improve description of mktime() / timegm().
rG7534109d13a6: libc: Improve description of mktime() / timegm().
Summary
  • Mention that mktime() and timegm() set errno on failure.
  • Correctly determining whether mktime() / timegm() succeeded with arbitrary input (where -1 can be a valid result) is non-trivial. Document the recommended procedure.

PR: 277863
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56779
Build 53667: arc lint + arc unit

Event Timeline

des created this revision.Mar 26 2024, 3:37 AM
Herald added a subscriber: imp. · View Herald TranscriptMar 26 2024, 3:37 AM
des requested review of this revision.Mar 26 2024, 3:37 AM
Harbormaster completed remote builds in B56779: Diff 136210.Mar 26 2024, 3:37 AM
pauamma_chezdork.com accepted this revision.Mar 26 2024, 3:44 AM
pauamma_chezdork.com added a subscriber: pauamma_chezdork.com.

Grammar and spelling LGTM. Correctness (or portability) of the recommended error-checking is beyond my ken.

This revision is now accepted and ready to land.Mar 26 2024, 3:44 AM
gbe accepted this revision.Mar 26 2024, 6:08 AM
gbe added a subscriber: gbe.

LGTM

des added a comment.Mar 26 2024, 11:26 AM
In D44503#1015085, @pauamma_gundo.com wrote:

Correctness (or portability) of the recommended error-checking is beyond my ken.

Don't worry, I take full responsibility for that :)

https://mm.icann.org/pipermail/tz/2024-March/058822.html

Closed by commit rG7534109d13a6: libc: Improve description of mktime() / timegm(). (authored by des). · Explain WhyMar 27 2024, 11:27 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG7534109d13a6: libc: Improve description of mktime() / timegm()..
des mentioned this in rG662dc74155ad: tzcode: Clean up the ctime(3) manual page..Apr 4 2024, 11:40 AM
des added a commit: rGfdde01c5b449: libc: Improve description of mktime() / timegm()..

Revision Contents
Changeset List

PathSize
lib/
libc/
stdtime/
18 lines

Diff 136210

View Options

lib/libc/stdtime/ctime.3

Loading...