Differential D44468

sys/acl.h: reduce header pollution
ClosedPublic
Actions

Authored by brooks on Mar 21 2024, 11:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Aug 15, 3:43 PM

	Unknown Object (File)
	Thu, Aug 14, 10:12 PM

	Unknown Object (File)
	Mon, Aug 11, 12:46 AM

	Unknown Object (File)
	Wed, Aug 6, 7:55 AM

	Unknown Object (File)
	Jul 19 2025, 7:03 AM

	Unknown Object (File)
	Jul 19 2025, 6:07 AM

	Unknown Object (File)
	Jul 19 2025, 4:48 AM

	Unknown Object (File)
	Jul 19 2025, 4:47 AM

View All 78 Files

Subscribers

None

Details

Reviewers

kib
imp
trasz

Commits

rGdcda49233de3: sys/acl.h: reduce header pollution

Summary

In commit d1dfd921774f0 the acl allocator was switch from malloc(9) to
uma(9) and done in a way required vm/uma.h and prerequisites. This added
considerable header pollution to sys/sysproto.h. The uma details were
hidden in commit b998d381f2868, but the header pollution remained. Add
an include of sys/malloc.h as required by commit ae1add4e55214 to keep
the header self contained.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56743
Build 53631: arc lint + arc unit

Event Timeline

brooks requested review of this revision.Mar 21 2024, 11:39 PM

brooks created this revision.

Harbormaster completed remote builds in B56734: Diff 136056.Mar 21 2024, 11:39 PM

brooks added a parent revision: D44467: sysproto.h: sys/acl.h -> sys/types.h.Mar 21 2024, 11:39 PM

Also, to be really self-contained, the header needs at least either sys/_types.h or sys/types.h (not sure which).

sys/sys/acl.h
39–43	Can we limit this to _KERNEL?

Put ifdef _KERNEL around sys/malloc.h include
Add sys/types.h and sys/_null.h

Harbormaster completed remote builds in B56743: Diff 136101.Mar 22 2024, 8:24 PM

brooks added a parent revision: D44474: acl_to_text: include sys/param.h for MAXLOGNAME.Mar 22 2024, 8:27 PM

kib accepted this revision.Mar 23 2024, 6:56 AM

This revision is now accepted and ready to land.Mar 23 2024, 6:56 AM

Closed by commit rGdcda49233de3: sys/acl.h: reduce header pollution (authored by brooks). · Explain WhyApr 15 2024, 8:44 PM

This revision was automatically updated to reflect the committed changes.

brooks marked an inline comment as done.

brooks added a commit: rGdcda49233de3: sys/acl.h: reduce header pollution.

Revision Contents
Changeset List

Path

Size

sys/

sys/

8 lines

Diff 136101

sys/sys/acl.h

Loading...