lorder: Undeprecate.
ClosedPublic
Actions

Authored by des on Feb 27 2024, 10:39 PM.

Details

Reviewers

imp
emaste
allanjude

Group Reviewers

Klara

Commits

rGcf4d9bf8b388: lorder: Undeprecate.

Summary

While lorder is not required by our current toolchain (or any toolchain
we've used in the past decade or two), it still occasionally shows up
in build systems of third party software, including The Open Group's
UNIX conformance test suite, and the maintenance cost is negligible.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56320
Build 53208: arc lint + arc unit

Event Timeline

des created this revision.Feb 27 2024, 10:39 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 27 2024, 10:39 PM

des requested review of this revision.Feb 27 2024, 10:39 PM

des added a parent revision: D44134: lorder: Add unit tests..

Harbormaster completed remote builds in B56310: Diff 135134.Feb 27 2024, 10:40 PM

imp accepted this revision.Feb 27 2024, 11:22 PM

This revision is now accepted and ready to land.Feb 27 2024, 11:22 PM

What do you think about a comment explaining why it is retained? something like "is not required by contemporary linkers, but it is still expected by some third party software build systems."

explain why we're keeping it

This revision now requires review to proceed.Feb 28 2024, 3:39 AM

Harbormaster completed remote builds in B56320: Diff 135147.Feb 28 2024, 3:39 AM

emaste accepted this revision.Feb 28 2024, 1:21 PM

This revision is now accepted and ready to land.Feb 28 2024, 1:21 PM