Page MenuHomeFreeBSD
Differential D43941

sdiff: Fix --expand-tabs and --tabsize.
ClosedPublic
Actions

Authored by des on Feb 16 2024, 6:57 PM.
Tags
None
Referenced Files
F174359940: D43941.id134458.diff
Fri, Oct 2, 4:26 PM
Unknown Object (File)
Wed, Sep 30, 8:08 PM
Unknown Object (File)
Mon, Sep 28, 2:07 AM
Unknown Object (File)
Sun, Sep 20, 8:16 AM
Unknown Object (File)
Sun, Sep 20, 8:15 AM
Unknown Object (File)
Tue, Sep 8, 3:57 PM
Unknown Object (File)
Sun, Sep 6, 9:16 AM
Unknown Object (File)
Sat, Sep 5, 3:23 PM
View All Files
Subscribers
imp
markj

Details

Reviewers
markj
Group Reviewers
Klara
Commits
rG174337b9eca0: sdiff: Fix --expand-tabs and --tabsize.
rGa834edfccd14: sdiff: Fix --expand-tabs and --tabsize.
Summary

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Feb 16 2024, 6:57 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 16 2024, 6:57 PM
des requested review of this revision.Feb 16 2024, 6:57 PM
Harbormaster completed remote builds in B56062: Diff 134458.Feb 16 2024, 6:57 PM
des added a child revision: D43942: sdiff: Fix binary case..Feb 16 2024, 6:57 PM
markj added a subscriber: markj.Feb 17 2024, 1:53 PM
markj added inline comments.
usr.bin/sdiff/sdiff.c
73

Should this part of the change have been in the "cleanup" commit?

526

Shouldn't this take --tabsize into account?

des retitled this revision from sdiff: Fix --expand-tabs option. to sdiff: Fix --expand-tabs and --tabsize..Feb 18 2024, 10:46 AM
des updated this revision to Diff 134555.Feb 18 2024, 11:02 AM

fix --tabsize too

Harbormaster completed remote builds in B56085: Diff 134555.Feb 18 2024, 11:03 AM
des added a parent revision: D43943: sdiff: Misc cleanup..Feb 18 2024, 11:03 AM
des marked 2 inline comments as done.
markj accepted this revision as: markj.Feb 18 2024, 4:34 PM
This revision is now accepted and ready to land.Feb 18 2024, 4:34 PM
Closed by commit rGa834edfccd14: sdiff: Fix --expand-tabs and --tabsize. (authored by des). · Explain WhyFeb 18 2024, 5:42 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGa834edfccd14: sdiff: Fix --expand-tabs and --tabsize..
des mentioned this in rG181e9683778e: sdiff: Misc cleanup..Feb 24 2024, 12:16 PM
des added a commit: rG174337b9eca0: sdiff: Fix --expand-tabs and --tabsize..Aug 1 2024, 4:47 PM

Revision Contents
Changeset List

PathSize
usr.bin/
sdiff/
4 lines
32 lines
tests/
18 lines

Diff 134577

View Options

usr.bin/sdiff/sdiff.1

Loading...
View Options

usr.bin/sdiff/sdiff.c

Loading...
View Options

usr.bin/sdiff/tests/sdiff_test.sh

Loading...