Page MenuHomeFreeBSD

sdiff: Fix binary case.
ClosedPublic

Authored by des on Feb 16 2024, 6:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 12:39 AM
Unknown Object (File)
Sun, Oct 12, 3:24 AM
Unknown Object (File)
Fri, Oct 10, 7:32 AM
Unknown Object (File)
Tue, Oct 7, 7:37 AM
Unknown Object (File)
Sat, Sep 27, 4:42 AM
Unknown Object (File)
Mon, Sep 22, 7:21 PM
Unknown Object (File)
Sep 14 2025, 12:37 AM
Unknown Object (File)
Sep 13 2025, 4:51 AM
Subscribers

Details

Reviewers
markj
Group Reviewers
Klara
Commits
rGad7bef8b8907: sdiff: Fix binary case.
Summary

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Feb 16 2024, 6:57 PM

Could you please explain the underlying problem that's fixed here?

Could you please explain the underlying problem that's fixed here?

if tmp1 != NULL then filename1 == tmp1, likewise for tmp2 and filename2, so we're deleting the file, then freeing the filename, then passing the freed name of a deleted file to diff and expecting that to work.

This revision is now accepted and ready to land.Feb 18 2024, 4:35 PM
This revision was automatically updated to reflect the committed changes.