Page MenuHomeFreeBSD
Differential D43942

sdiff: Fix binary case.
ClosedPublic
Actions

Authored by des on Feb 16 2024, 6:57 PM.
Tags
None
Referenced Files
F151270310: D43942.id134578.diff
Tue, Apr 7, 5:47 AM
Unknown Object (File)
Mon, Apr 6, 1:05 AM
Unknown Object (File)
Sat, Apr 4, 1:02 PM
Unknown Object (File)
Sat, Apr 4, 5:15 AM
Unknown Object (File)
Sat, Apr 4, 3:49 AM
Unknown Object (File)
Fri, Apr 3, 10:16 PM
Unknown Object (File)
Thu, Apr 2, 6:46 AM
Unknown Object (File)
Sat, Mar 28, 12:22 PM
View All Files
Subscribers
imp
markj

Details

Reviewers
markj
Group Reviewers
Klara
Commits
rGad7bef8b8907: sdiff: Fix binary case.
Summary

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Feb 16 2024, 6:57 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 16 2024, 6:57 PM
des requested review of this revision.Feb 16 2024, 6:57 PM
Harbormaster completed remote builds in B56063: Diff 134459.Feb 16 2024, 6:57 PM
des added a parent revision: D43941: sdiff: Fix --expand-tabs and --tabsize..Feb 16 2024, 6:57 PM
des added a child revision: D43943: sdiff: Misc cleanup..
markj added a subscriber: markj.Feb 17 2024, 1:54 PM

Could you please explain the underlying problem that's fixed here?

des added a comment.Feb 18 2024, 10:03 AM
In D43942#1002499, @markj wrote:

Could you please explain the underlying problem that's fixed here?

if tmp1 != NULL then filename1 == tmp1, likewise for tmp2 and filename2, so we're deleting the file, then freeing the filename, then passing the freed name of a deleted file to diff and expecting that to work.

des updated this revision to Diff 134556.Feb 18 2024, 11:02 AM

add test

Harbormaster completed remote builds in B56086: Diff 134556.Feb 18 2024, 11:03 AM
des removed a child revision: D43943: sdiff: Misc cleanup..Feb 18 2024, 11:03 AM
markj accepted this revision as: markj.Feb 18 2024, 4:35 PM
This revision is now accepted and ready to land.Feb 18 2024, 4:35 PM
Closed by commit rGad7bef8b8907: sdiff: Fix binary case. (authored by des). · Explain WhyFeb 18 2024, 5:42 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGad7bef8b8907: sdiff: Fix binary case..
des mentioned this in rG181e9683778e: sdiff: Misc cleanup..Feb 24 2024, 12:16 PM
des mentioned this in rG174337b9eca0: sdiff: Fix --expand-tabs and --tabsize..Aug 1 2024, 4:47 PM

Revision Contents
Changeset List

PathSize
usr.bin/
sdiff/
100 lines
tests/
18 lines

Diff 134578

View Options

usr.bin/sdiff/sdiff.c

Loading...
View Options

usr.bin/sdiff/tests/sdiff_test.sh

Loading...