Page MenuHomeFreeBSD
Differential D43924

emulators/dosbox-staging: update to 0.81.0
ClosedPublic
Actions

Authored by vvd on Feb 15 2024, 7:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 14, 7:28 PM
Unknown Object (File)
Wed, Aug 12, 3:17 PM
Unknown Object (File)
Wed, Aug 12, 2:20 PM
Unknown Object (File)
Tue, Aug 11, 10:00 PM
Unknown Object (File)
Mon, Aug 10, 10:57 AM
Unknown Object (File)
Mon, Aug 10, 9:47 AM
Unknown Object (File)
Sun, Aug 9, 5:05 PM
Unknown Object (File)
Sat, Aug 8, 4:12 AM
View All Files
Subscribers
None

Details

Reviewers
makc
arrowd
adamw
tcberner
Commits
R11:04d41f9a48a5: emulators/dosbox-staging: update to 0.81.0
Summary

Release notes:
https://dosbox-staging.github.io/releases/release-notes/0.81.0/

Tested with different combinations of options in poudriere and in live system 13.2-p9 amd64.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 56050
Build 52939: arc lint + arc unit

Event Timeline

vvd requested review of this revision.Feb 15 2024, 7:17 PM
vvd created this revision.
Harbormaster completed remote builds in B56050: Diff 134393.Feb 15 2024, 7:17 PM
arrowd added inline comments.Feb 15 2024, 7:23 PM
emulators/dosbox-staging/Makefile
37

Should this really be an option? We generally strive for using system libs as much as possible and this dependency is tiny anyways.

vvd added inline comments.Feb 15 2024, 7:33 PM
emulators/dosbox-staging/Makefile
37

AFAIK zlib-ng is optimized compared to classic zlib.
Maybe somebody don't want install it.
In any case, the choice is up to the maintainer.

makc added inline comments.Feb 15 2024, 7:50 PM
emulators/dosbox-staging/Makefile
37

Upstream prefers to use zlib-ng, so I'd make it non-optional.

vvd added inline comments.Feb 15 2024, 7:53 PM
emulators/dosbox-staging/Makefile
37

Ok.
Should I update the patch or will you fix it and commit it yourself?

makc added inline comments.Feb 15 2024, 8:06 PM
emulators/dosbox-staging/Makefile
37

just add archivers/zlib-ng directly to the LIB_DEPENDS (please keep it sorted by directories) and you may commit with my approval.

arrowd accepted this revision.Feb 15 2024, 8:18 PM
This revision is now accepted and ready to land.Feb 15 2024, 8:18 PM
vvd updated this revision to Diff 134400.Feb 15 2024, 8:42 PM

Done.

This revision now requires review to proceed.Feb 15 2024, 8:42 PM
Harbormaster completed remote builds in B56051: Diff 134400.Feb 15 2024, 8:42 PM
makc accepted this revision.Feb 15 2024, 8:49 PM

Ship it!

This revision is now accepted and ready to land.Feb 15 2024, 8:49 PM
Closed by commit R11:04d41f9a48a5: emulators/dosbox-staging: update to 0.81.0 (authored by vvd). · Explain WhyFeb 15 2024, 8:50 PM
This revision was automatically updated to reflect the committed changes.
vvd added a commit: R11:04d41f9a48a5: emulators/dosbox-staging: update to 0.81.0.

Revision Contents
Changeset List

PathSize
emulators/
dosbox-staging/
17 lines
6 lines
files/
12 lines
83 lines

Diff 134393

View Options

emulators/dosbox-staging/Makefile

Loading...
View Options

emulators/dosbox-staging/distinfo

Loading...
View Options

emulators/dosbox-staging/files/patch-meson.build

Loading...
View Options

emulators/dosbox-staging/pkg-plist

Loading...