Page MenuHomeFreeBSD
Differential D43717

speaker: Use standard C bool
ClosedPublic
Actions

Authored by jhb on Feb 2 2024, 11:29 PM.
Tags
None
Referenced Files
F169538317: D43717.id133897.diff
Tue, Sep 1, 8:51 PM
F169516691: D43717.id133779.diff
Tue, Sep 1, 7:08 PM
F169502199: D43717.id.diff
Tue, Sep 1, 5:45 PM
Unknown Object (File)
Sat, Aug 22, 4:22 PM
Unknown Object (File)
Mon, Aug 17, 6:07 PM
Unknown Object (File)
Sat, Aug 15, 1:14 AM
Unknown Object (File)
Fri, Aug 14, 6:46 AM
Unknown Object (File)
Wed, Aug 12, 5:07 PM
View All Files
Subscribers
afedorov
imp

Details

Reviewers
markj
Commits
rG47a375d2bae6: speaker: Use standard C bool
rG8bebcb26763a: speaker: Use standard C bool
rGc83d83206a39: speaker: Use standard C bool

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Feb 2 2024, 11:29 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 2 2024, 11:29 PM
jhb requested review of this revision.Feb 2 2024, 11:29 PM
Harbormaster completed remote builds in B55768: Diff 133779.Feb 2 2024, 11:29 PM
markj accepted this revision.Feb 3 2024, 7:12 PM
This revision is now accepted and ready to land.Feb 3 2024, 7:12 PM
afedorov added a subscriber: afedorov.Feb 5 2024, 12:46 PM
afedorov added inline comments.
sys/dev/speaker/spkr.c
393

static int -> static bool

jhb marked an inline comment as done.Feb 5 2024, 11:40 PM
jhb added inline comments.
sys/dev/speaker/spkr.c
393

Nice catch, thanks

Closed by commit rGc83d83206a39: speaker: Use standard C bool (authored by jhb). · Explain WhyFeb 5 2024, 11:46 PM
This revision was automatically updated to reflect the committed changes.
jhb marked an inline comment as done.
jhb added a commit: rGc83d83206a39: speaker: Use standard C bool.
jhb added a commit: rG8bebcb26763a: speaker: Use standard C bool.Nov 30 2024, 4:52 PM
jhb added a commit: rG47a375d2bae6: speaker: Use standard C bool.

Revision Contents
Changeset List

PathSize
sys/
dev/
speaker/
28 lines

Diff 133897

View Options

sys/dev/speaker/spkr.c

Loading...