acl: Check that perl is available before using it
AbandonedPublic
Actions

Authored by jhb on Feb 2 2024, 6:27 PM.

Details

Reviewers

brooks
markj

Summary

Obtained from: CheriBSD

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 55764
Build 52653: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 2 2024, 6:27 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 2 2024, 6:27 PM

jhb requested review of this revision.Feb 2 2024, 6:27 PM

Harbormaster completed remote builds in B55764: Diff 133764.Feb 2 2024, 6:27 PM

tests/sys/acl/Makefile includes perl in the list of required programs.

I tend to think that it's better to provide that metadata in the test file itself, but why isn't the required_programs annotation being respected?

Hmm, I noticed this diff in CheriBSD when merging the mdctl change. It maybe that the change in CheriBSD is just old and no longer needed. The original change in CheriBSD was from 2016:

commit d88a4595aba0d62c4f40f2bfbf650107c0c45e7b
Author: Brooks Davis <brooks@one-eyed-alien.net>
Date:   Wed Jun 29 23:27:48 2016 +0000

    Check that perl is available before using it.

The change to add perl to required_programs was around the same time upstream:

commit 1fe8c3077f04e1c570ad12ea120e15b9c9acbb93
Author: Alan Somers <asomers@FreeBSD.org>
Date:   Mon Jun 20 23:17:00 2016 +0000

    Skip sys/acl tests on systems lacking perl
    
    tests/sys/acl/Makefile
            add perl to the required_programs for all tests in this directory

but merged to CheriBSD in late August, so probably I should just drop this change in CheriBSD instead.