Page MenuHomeFreeBSD
Differential D5298

AXP209 Power Management Unit temperature sensor support
ClosedPublic
Actions

Authored by jmcneill_invisible.ca on Feb 16 2016, 11:05 AM.
Tags
Referenced Files
F133680948: D5298.id.diff
Mon, Oct 27, 1:26 PM
F133678944: D5298.id13359.diff
Mon, Oct 27, 12:57 PM
F133678938: D5298.id13356.diff
Mon, Oct 27, 12:57 PM
F133678935: D5298.id13364.diff
Mon, Oct 27, 12:57 PM
F133678934: D5298.id.diff
Mon, Oct 27, 12:57 PM
Unknown Object (File)
Mon, Oct 27, 7:46 AM
Unknown Object (File)
Sat, Oct 25, 1:43 AM
Unknown Object (File)
Thu, Oct 9, 8:40 AM
View All Files
Subscribers
andrew
imp

Details

Reviewers
None
Group Reviewers
ARM
Commits
rS295658: Add a sysctl to read the internal temperature of the AXP209 Power
Summary

This change exposes the AXP209 Power Management "Internal temperature" sensor via sysctl:

dev.axp209_pmu.0.temp: 26.1C

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2525
Build 2542: arc lint + arc unit

Event Timeline

jmcneill_invisible.ca updated this revision to Diff 13356.Feb 16 2016, 11:05 AM
jmcneill_invisible.ca retitled this revision from to AXP209 Power Management Unit temperature sensor support.
jmcneill_invisible.ca updated this object.
jmcneill_invisible.ca edited the test plan for this revision. (Show Details)
jmcneill_invisible.ca added a reviewer: ARM.
jmcneill_invisible.ca set the repository for this revision to rS FreeBSD src repository - subversion.
jmcneill_invisible.ca added a project: ARM.
Herald added subscribers: andrew, imp. · View Herald TranscriptFeb 16 2016, 11:05 AM
andrew added a comment.Feb 16 2016, 11:10 AM

You might need to rebase on my recent change

sys/arm/allwinner/axp209.c
202

You don't seem to be using AXP209_TEMP in the sysctl handler.

jmcneill_invisible.ca added inline comments.Feb 16 2016, 11:13 AM
sys/arm/allwinner/axp209.c
202

I figured we'd eventually add other sensors (voltage etc). Should I pass 0 for now?

andrew added inline comments.Feb 16 2016, 11:22 AM
sys/arm/allwinner/axp209.c
202

I would check the value in axp209_sysctl and return ENOENT if it's invalid.

jmcneill_invisible.ca updated this revision to Diff 13359.Feb 16 2016, 11:31 AM

Added test for sensor type in axp209_sensor, cleanup whitespace.

Closed by commit rS295658: Add a sysctl to read the internal temperature of the AXP209 Power (authored by andrew). · Explain WhyFeb 16 2016, 11:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
arm/
allwinner/
41 lines

Diff 13359

View Options

sys/arm/allwinner/axp209.c

Loading...