Page MenuHomeFreeBSD
Differential D43533

bintrans: Avoid leaking a stack pointer through a global.
AbandonedPublic
Actions

Authored by des on Jan 21 2024, 5:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 14, 1:48 AM
Unknown Object (File)
Sat, Feb 22, 2:34 PM
Unknown Object (File)
Jan 29 2025, 4:18 AM
Unknown Object (File)
Jan 24 2025, 7:31 PM
Unknown Object (File)
Jan 9 2025, 12:02 PM
Unknown Object (File)
Jan 8 2025, 10:08 PM
Unknown Object (File)
Oct 7 2024, 9:37 PM
Unknown Object (File)
Sep 28 2024, 1:23 AM
View All 28 Files
Subscribers
imp

Details

Reviewers
None
Group Reviewers
Klara
Summary

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 55521
Build 52410: arc lint + arc unit

Event Timeline

des created this revision.Jan 21 2024, 5:37 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 21 2024, 5:37 PM
des requested review of this revision.Jan 21 2024, 5:37 PM
Harbormaster completed remote builds in B55521: Diff 133116.Jan 21 2024, 5:37 PM
des added a parent revision: D43532: bintrans: Error out if writing to the output failed..Jan 21 2024, 5:37 PM
des added a child revision: D43534: bintrans: Fix uninitialized variable..
des added a reviewer: manpages.Jan 23 2024, 12:55 PM
des removed a reviewer: manpages.
des added a comment.Jan 23 2024, 12:58 PM

On second thought, this would result in base64_decode() and uu_decode() showing the wrong file name in error messages since they use outfile and don't have routfile in scope...

des abandoned this revision.Jan 23 2024, 1:00 PM
des removed a child revision: D43534: bintrans: Fix uninitialized variable..
des removed a parent revision: D43532: bintrans: Error out if writing to the output failed..

Revision Contents
Changeset List

PathSize
usr.bin/
bintrans/
23 lines

Diff 133116

View Options

usr.bin/bintrans/uudecode.c

Show First 20 Lines • Show All 4,094 Lines • ▼ Show 20 Lines
libkern/strtol.c standard libkern/strtol.c standard
libkern/strtoq.c standard libkern/strtoq.c standard
libkern/strtoul.c standard libkern/strtoul.c standard
libkern/strtouq.c standard libkern/strtouq.c standard
libkern/strvalid.c standard libkern/strvalid.c standard
libkern/timingsafe_bcmp.c standard libkern/timingsafe_bcmp.c standard
contrib/zlib/adler32.c optional crypto | geom_uzip | \ contrib/zlib/adler32.c optional crypto | geom_uzip | \
mxge | ddb_ctf | gzio | zfs | zlib \ mxge | ddb_ctf | gzio | zfs | zlib \
compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" compile-with "${ZLIB_C}"
contrib/zlib/compress.c optional crypto | geom_uzip | \ contrib/zlib/compress.c optional crypto | geom_uzip | \
mxge | ddb_ctf | gzio | zfs | zlib \ mxge | ddb_ctf | gzio | zfs | zlib \
compile-with "${NORMAL_C} -Wno-cast-qual -Wno-deprecated-non-prototype" compile-with "${ZLIB_C}"
contrib/zlib/crc32.c optional crypto | geom_uzip | \ contrib/zlib/crc32.c optional crypto | geom_uzip | \
mxge | ddb_ctf | gzio | zfs | zlib \ mxge | ddb_ctf | gzio | zfs | zlib \
compile-with "${NORMAL_C} ${NO_WSTRICT_PROTOTYPES}" compile-with "${ZLIB_C}"
contrib/zlib/deflate.c optional crypto | geom_uzip | \ contrib/zlib/deflate.c optional crypto | geom_uzip | \
mxge | ddb_ctf | gzio | zfs | zlib \ mxge | ddb_ctf | gzio | zfs | zlib \
compile-with "${NORMAL_C} -Wno-cast-qual -Wno-deprecated-non-prototype" compile-with "${ZLIB_C}"
contrib/zlib/inffast.c optional crypto | geom_uzip | \ contrib/zlib/inffast.c optional crypto | geom_uzip | \
mxge | ddb_ctf | gzio | zfs | zlib \ mxge | ddb_ctf | gzio | zfs | zlib \
compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" compile-with "${ZLIB_C}"
contrib/zlib/inflate.c optional crypto | geom_uzip | \ contrib/zlib/inflate.c optional crypto | geom_uzip | \
mxge | ddb_ctf | gzio | zfs | zlib \ mxge | ddb_ctf | gzio | zfs | zlib \
compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" compile-with "${ZLIB_C}"
contrib/zlib/inftrees.c optional crypto | geom_uzip | \ contrib/zlib/inftrees.c optional crypto | geom_uzip | \
mxge | ddb_ctf | gzio | zfs | zlib \ mxge | ddb_ctf | gzio | zfs | zlib \
compile-with "${NORMAL_C} -Wno-deprecated-non-prototype" compile-with "${ZLIB_C}"
contrib/zlib/trees.c optional crypto | geom_uzip | \ contrib/zlib/trees.c optional crypto | geom_uzip | \
mxge | ddb_ctf | gzio | zfs | zlib \ mxge | ddb_ctf | gzio | zfs | zlib \
compile-with "${NORMAL_C} ${NO_WSTRICT_PROTOTYPES}" compile-with "${ZLIB_C}"
contrib/zlib/uncompr.c optional crypto | geom_uzip | \ contrib/zlib/uncompr.c optional crypto | geom_uzip | \
mxge | ddb_ctf | gzio | zfs | zlib \ mxge | ddb_ctf | gzio | zfs | zlib \
compile-with "${NORMAL_C} -Wno-cast-qual -Wno-deprecated-non-prototype" compile-with "${ZLIB_C}"
contrib/zlib/zutil.c optional crypto | geom_uzip | \ contrib/zlib/zutil.c optional crypto | geom_uzip | \
mxge | ddb_ctf | gzio | zfs | zlib \ mxge | ddb_ctf | gzio | zfs | zlib \
compile-with "${NORMAL_C} ${NO_WSTRICT_PROTOTYPES}" compile-with "${ZLIB_C}"
dev/zlib/zlib_mod.c optional crypto | geom_uzip | \ dev/zlib/zlib_mod.c optional crypto | geom_uzip | \
mxge | ddb_ctf | gzio | zfs | zlib mxge | ddb_ctf | gzio | zfs | zlib
dev/zlib/zcalloc.c optional crypto | geom_uzip | \ dev/zlib/zcalloc.c optional crypto | geom_uzip | \
mxge | ddb_ctf | gzio | zfs | zlib mxge | ddb_ctf | gzio | zfs | zlib
net/altq/altq_cbq.c optional altq net/altq/altq_cbq.c optional altq
net/altq/altq_codel.c optional altq net/altq/altq_codel.c optional altq
net/altq/altq_hfsc.c optional altq net/altq/altq_hfsc.c optional altq
net/altq/altq_fairq.c optional altq net/altq/altq_fairq.c optional altq
▲ Show 20 Lines • Show All 1,127 Lines • Show Last 20 Lines