Page MenuHomeFreeBSD
Differential D43468

fwget: Update for Radeon RX 7900 XT (RDNA3) PCI-ID
ClosedPublic
Actions

Authored by meka_tilda.center on Jan 16 2024, 6:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 8:46 PM
Unknown Object (File)
Mon, Nov 25, 11:31 AM
Unknown Object (File)
Mon, Nov 25, 12:01 AM
Unknown Object (File)
Sun, Nov 24, 2:02 AM
Unknown Object (File)
Sat, Nov 23, 4:50 AM
Unknown Object (File)
Fri, Nov 22, 10:32 AM
Unknown Object (File)
Fri, Nov 22, 5:36 AM
Unknown Object (File)
Thu, Nov 21, 8:35 AM
View All Files
Subscribers
imp

Details

Reviewers
manu
Commits
rGef44785cab8e: fwget: Update for Radeon RX 7900 XT (RDNA3) PCI-ID
rGf59662030254: fwget: Update for Radeon RX 7900 XT (RDNA3) PCI-ID
Summary

Latest DRM/firmware added support for RDNA3 based GPUs, update fwget with the proper PCI ID.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

meka_tilda.center created this revision.Jan 16 2024, 6:45 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 16 2024, 6:45 PM
meka_tilda.center requested review of this revision.Jan 16 2024, 6:45 PM

It would be better if addpkg supported multiple arguments, but with current implementation we have to use multiple invocations.

manu added a comment.Jan 16 2024, 6:49 PM
In D43468#990935, @meka_tilda.center wrote:

It would be better if addpkg supported multiple arguments, but with current implementation we have to use multiple invocations.

It does, see https://cgit.freebsd.org/src/tree/usr.sbin/fwget/pci/pci_video_amd#n39

manu requested changes to this revision.Jan 16 2024, 6:49 PM
This revision now requires changes to proceed.Jan 16 2024, 6:49 PM
meka_tilda.center updated this revision to Diff 132842.Jan 16 2024, 6:55 PM

Ah, so, single argument with quotes. If broken into multiple lines with "\" it makes fwget's output weird, hence one huge line.

manu added a comment.Jan 16 2024, 7:05 PM
In D43468#990940, @meka_tilda.center wrote:

Ah, so, single argument with quotes. If broken into multiple lines with "\" it makes fwget's output weird, hence one huge line.

Weird how ?

meka_tilda.center added a comment.EditedJan 16 2024, 7:08 PM

An example

# fwget
Needed firmware packages: 'gpu-firmware-amd-kmod-dcn-3-2-0 				gpu-firmware-amd-kmod-gc-11-0-0 				gpu-firmware-amd-kmod-psp-13-0-0 				gpu-firmware-amd-kmod-smu-13-0-0 				gpu-firmware-amd-kmod-sdma-6-0-0 				gpu-firmware-amd-kmod-vcn-4-0-0'
The most recent versions of packages are already installed

This is the part of the code that produced that output

# git diff
diff --git a/usr.sbin/fwget/pci/pci_video_amd b/usr.sbin/fwget/pci/pci_video_amd
index f1bd9c6aaceb..b70d8c67e692 100644
--- a/usr.sbin/fwget/pci/pci_video_amd
+++ b/usr.sbin/fwget/pci/pci_video_amd
@@ -136,7 +136,12 @@ pci_video_amd()
                        addpkg "gpu-firmware-amd-kmod-beige-goby"
                        ;;
                0x744c)
-                       addpkg "gpu-firmware-amd-kmod-dcn-3-2-0 gpu-firmware-amd-kmod-gc-11-0-0 gpu-firmware-amd-kmod-psp-13-0-0 gpu-firmware-amd-kmod-smu-13-0-0 gpu-firmware-amd-kmod-sdma-6-0-0 gpu-firmware-amd-kmod-vcn-4-0-0"
+                       addpkg "gpu-firmware-amd-kmod-dcn-3-2-0 \
+                               gpu-firmware-amd-kmod-gc-11-0-0 \
+                               gpu-firmware-amd-kmod-psp-13-0-0 \
+                               gpu-firmware-amd-kmod-smu-13-0-0 \
+                               gpu-firmware-amd-kmod-sdma-6-0-0 \
+                               gpu-firmware-amd-kmod-vcn-4-0-0"
                        ;;
        esac
 }
manu requested changes to this revision.Jan 17 2024, 8:28 AM
In D43468#990965, @meka_tilda.center wrote:

An example

# fwget
Needed firmware packages: 'gpu-firmware-amd-kmod-dcn-3-2-0 				gpu-firmware-amd-kmod-gc-11-0-0 				gpu-firmware-amd-kmod-psp-13-0-0 				gpu-firmware-amd-kmod-smu-13-0-0 				gpu-firmware-amd-kmod-sdma-6-0-0 				gpu-firmware-amd-kmod-vcn-4-0-0'
The most recent versions of packages are already installed

This is the part of the code that produced that output

# git diff
diff --git a/usr.sbin/fwget/pci/pci_video_amd b/usr.sbin/fwget/pci/pci_video_amd
index f1bd9c6aaceb..b70d8c67e692 100644
--- a/usr.sbin/fwget/pci/pci_video_amd
+++ b/usr.sbin/fwget/pci/pci_video_amd
@@ -136,7 +136,12 @@ pci_video_amd()
                        addpkg "gpu-firmware-amd-kmod-beige-goby"
                        ;;
                0x744c)
-                       addpkg "gpu-firmware-amd-kmod-dcn-3-2-0 gpu-firmware-amd-kmod-gc-11-0-0 gpu-firmware-amd-kmod-psp-13-0-0 gpu-firmware-amd-kmod-smu-13-0-0 gpu-firmware-amd-kmod-sdma-6-0-0 gpu-firmware-amd-kmod-vcn-4-0-0"
+                       addpkg "gpu-firmware-amd-kmod-dcn-3-2-0 \
+                               gpu-firmware-amd-kmod-gc-11-0-0 \
+                               gpu-firmware-amd-kmod-psp-13-0-0 \
+                               gpu-firmware-amd-kmod-smu-13-0-0 \
+                               gpu-firmware-amd-kmod-sdma-6-0-0 \
+                               gpu-firmware-amd-kmod-vcn-4-0-0"
                        ;;
        esac
 }

Ok I see, then sorry to ask this but the first version (with multiple call to addpkg) is prettier, can you update again ? :)

This revision now requires changes to proceed.Jan 17 2024, 8:28 AM
meka_tilda.center updated this revision to Diff 132864.Jan 17 2024, 9:27 AM
manu accepted this revision.Jan 17 2024, 9:34 AM

Thanks.

This revision is now accepted and ready to land.Jan 17 2024, 9:34 AM
Closed by commit rGf59662030254: fwget: Update for Radeon RX 7900 XT (RDNA3) PCI-ID (authored by meka_tilda.center, committed by manu). · Explain WhyJan 17 2024, 9:38 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rGf59662030254: fwget: Update for Radeon RX 7900 XT (RDNA3) PCI-ID.
manu added a commit: rGef44785cab8e: fwget: Update for Radeon RX 7900 XT (RDNA3) PCI-ID.Jun 4 2024, 11:39 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
fwget/
pci/
3 lines

Diff 132842

View Options

usr.sbin/fwget/pci/pci_video_amd

Loading...