Page MenuHomeFreeBSD

fwget: Update for Radeon RX 7900 XT (RDNA3) PCI-ID
ClosedPublic

Authored by meka_tilda.center on Jan 16 2024, 6:45 PM.
Tags
None
Referenced Files
F99659109: D43468.id132842.diff
Fri, Oct 11, 8:27 PM
Unknown Object (File)
Thu, Oct 10, 6:21 PM
Unknown Object (File)
Thu, Oct 10, 11:48 AM
Unknown Object (File)
Thu, Oct 10, 7:53 AM
Unknown Object (File)
Wed, Oct 9, 2:40 PM
Unknown Object (File)
Wed, Oct 9, 2:23 AM
Unknown Object (File)
Mon, Oct 7, 1:18 AM
Unknown Object (File)
Sun, Oct 6, 12:38 AM
Subscribers

Details

Summary

Latest DRM/firmware added support for RDNA3 based GPUs, update fwget with the proper PCI ID.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

It would be better if addpkg supported multiple arguments, but with current implementation we have to use multiple invocations.

It would be better if addpkg supported multiple arguments, but with current implementation we have to use multiple invocations.

It does, see https://cgit.freebsd.org/src/tree/usr.sbin/fwget/pci/pci_video_amd#n39

manu requested changes to this revision.Jan 16 2024, 6:49 PM
This revision now requires changes to proceed.Jan 16 2024, 6:49 PM

Ah, so, single argument with quotes. If broken into multiple lines with "\" it makes fwget's output weird, hence one huge line.

Ah, so, single argument with quotes. If broken into multiple lines with "\" it makes fwget's output weird, hence one huge line.

Weird how ?

An example

# fwget
Needed firmware packages: 'gpu-firmware-amd-kmod-dcn-3-2-0 				gpu-firmware-amd-kmod-gc-11-0-0 				gpu-firmware-amd-kmod-psp-13-0-0 				gpu-firmware-amd-kmod-smu-13-0-0 				gpu-firmware-amd-kmod-sdma-6-0-0 				gpu-firmware-amd-kmod-vcn-4-0-0'
The most recent versions of packages are already installed

This is the part of the code that produced that output

# git diff
diff --git a/usr.sbin/fwget/pci/pci_video_amd b/usr.sbin/fwget/pci/pci_video_amd
index f1bd9c6aaceb..b70d8c67e692 100644
--- a/usr.sbin/fwget/pci/pci_video_amd
+++ b/usr.sbin/fwget/pci/pci_video_amd
@@ -136,7 +136,12 @@ pci_video_amd()
                        addpkg "gpu-firmware-amd-kmod-beige-goby"
                        ;;
                0x744c)
-                       addpkg "gpu-firmware-amd-kmod-dcn-3-2-0 gpu-firmware-amd-kmod-gc-11-0-0 gpu-firmware-amd-kmod-psp-13-0-0 gpu-firmware-amd-kmod-smu-13-0-0 gpu-firmware-amd-kmod-sdma-6-0-0 gpu-firmware-amd-kmod-vcn-4-0-0"
+                       addpkg "gpu-firmware-amd-kmod-dcn-3-2-0 \
+                               gpu-firmware-amd-kmod-gc-11-0-0 \
+                               gpu-firmware-amd-kmod-psp-13-0-0 \
+                               gpu-firmware-amd-kmod-smu-13-0-0 \
+                               gpu-firmware-amd-kmod-sdma-6-0-0 \
+                               gpu-firmware-amd-kmod-vcn-4-0-0"
                        ;;
        esac
 }
manu requested changes to this revision.Jan 17 2024, 8:28 AM

An example

# fwget
Needed firmware packages: 'gpu-firmware-amd-kmod-dcn-3-2-0 				gpu-firmware-amd-kmod-gc-11-0-0 				gpu-firmware-amd-kmod-psp-13-0-0 				gpu-firmware-amd-kmod-smu-13-0-0 				gpu-firmware-amd-kmod-sdma-6-0-0 				gpu-firmware-amd-kmod-vcn-4-0-0'
The most recent versions of packages are already installed

This is the part of the code that produced that output

# git diff
diff --git a/usr.sbin/fwget/pci/pci_video_amd b/usr.sbin/fwget/pci/pci_video_amd
index f1bd9c6aaceb..b70d8c67e692 100644
--- a/usr.sbin/fwget/pci/pci_video_amd
+++ b/usr.sbin/fwget/pci/pci_video_amd
@@ -136,7 +136,12 @@ pci_video_amd()
                        addpkg "gpu-firmware-amd-kmod-beige-goby"
                        ;;
                0x744c)
-                       addpkg "gpu-firmware-amd-kmod-dcn-3-2-0 gpu-firmware-amd-kmod-gc-11-0-0 gpu-firmware-amd-kmod-psp-13-0-0 gpu-firmware-amd-kmod-smu-13-0-0 gpu-firmware-amd-kmod-sdma-6-0-0 gpu-firmware-amd-kmod-vcn-4-0-0"
+                       addpkg "gpu-firmware-amd-kmod-dcn-3-2-0 \
+                               gpu-firmware-amd-kmod-gc-11-0-0 \
+                               gpu-firmware-amd-kmod-psp-13-0-0 \
+                               gpu-firmware-amd-kmod-smu-13-0-0 \
+                               gpu-firmware-amd-kmod-sdma-6-0-0 \
+                               gpu-firmware-amd-kmod-vcn-4-0-0"
                        ;;
        esac
 }

Ok I see, then sorry to ask this but the first version (with multiple call to addpkg) is prettier, can you update again ? :)

This revision now requires changes to proceed.Jan 17 2024, 8:28 AM
This revision is now accepted and ready to land.Jan 17 2024, 9:34 AM