fwget: Update for Radeon RX 7900 XT (RDNA3) PCI-ID

[meka_tilda.center]

Summary

Latest DRM/firmware added support for RDNA3 based GPUs, update fwget with the proper PCI ID.

[meka_tilda.center]

It would be better if addpkg supported multiple arguments, but with current implementation we have to use multiple invocations.

[manu]

In D43468#990935, @meka_tilda.center wrote:

It would be better if addpkg supported multiple arguments, but with current implementation we have to use multiple invocations.

It does, see https://cgit.freebsd.org/src/tree/usr.sbin/fwget/pci/pci_video_amd#n39

[meka_tilda.center]

Ah, so, single argument with quotes. If broken into multiple lines with "\" it makes fwget's output weird, hence one huge line.

[manu]

In D43468#990940, @meka_tilda.center wrote:

Ah, so, single argument with quotes. If broken into multiple lines with "\" it makes fwget's output weird, hence one huge line.

Weird how ?

[meka_tilda.center]

An example

# fwget
Needed firmware packages: 'gpu-firmware-amd-kmod-dcn-3-2-0 				gpu-firmware-amd-kmod-gc-11-0-0 				gpu-firmware-amd-kmod-psp-13-0-0 				gpu-firmware-amd-kmod-smu-13-0-0 				gpu-firmware-amd-kmod-sdma-6-0-0 				gpu-firmware-amd-kmod-vcn-4-0-0'
The most recent versions of packages are already installed

This is the part of the code that produced that output

# git diff
diff --git a/usr.sbin/fwget/pci/pci_video_amd b/usr.sbin/fwget/pci/pci_video_amd
index f1bd9c6aaceb..b70d8c67e692 100644
--- a/usr.sbin/fwget/pci/pci_video_amd
+++ b/usr.sbin/fwget/pci/pci_video_amd
@@ -136,7 +136,12 @@ pci_video_amd()
                        addpkg "gpu-firmware-amd-kmod-beige-goby"
                        ;;
                0x744c)
-                       addpkg "gpu-firmware-amd-kmod-dcn-3-2-0 gpu-firmware-amd-kmod-gc-11-0-0 gpu-firmware-amd-kmod-psp-13-0-0 gpu-firmware-amd-kmod-smu-13-0-0 gpu-firmware-amd-kmod-sdma-6-0-0 gpu-firmware-amd-kmod-vcn-4-0-0"
+                       addpkg "gpu-firmware-amd-kmod-dcn-3-2-0 \
+                               gpu-firmware-amd-kmod-gc-11-0-0 \
+                               gpu-firmware-amd-kmod-psp-13-0-0 \
+                               gpu-firmware-amd-kmod-smu-13-0-0 \
+                               gpu-firmware-amd-kmod-sdma-6-0-0 \
+                               gpu-firmware-amd-kmod-vcn-4-0-0"
                        ;;
        esac
 }

[manu]

In D43468#990965, @meka_tilda.center wrote:

An example

# fwget
Needed firmware packages: 'gpu-firmware-amd-kmod-dcn-3-2-0 				gpu-firmware-amd-kmod-gc-11-0-0 				gpu-firmware-amd-kmod-psp-13-0-0 				gpu-firmware-amd-kmod-smu-13-0-0 				gpu-firmware-amd-kmod-sdma-6-0-0 				gpu-firmware-amd-kmod-vcn-4-0-0'
The most recent versions of packages are already installed

This is the part of the code that produced that output

# git diff
diff --git a/usr.sbin/fwget/pci/pci_video_amd b/usr.sbin/fwget/pci/pci_video_amd
index f1bd9c6aaceb..b70d8c67e692 100644
--- a/usr.sbin/fwget/pci/pci_video_amd
+++ b/usr.sbin/fwget/pci/pci_video_amd
@@ -136,7 +136,12 @@ pci_video_amd()
                        addpkg "gpu-firmware-amd-kmod-beige-goby"
                        ;;
                0x744c)
-                       addpkg "gpu-firmware-amd-kmod-dcn-3-2-0 gpu-firmware-amd-kmod-gc-11-0-0 gpu-firmware-amd-kmod-psp-13-0-0 gpu-firmware-amd-kmod-smu-13-0-0 gpu-firmware-amd-kmod-sdma-6-0-0 gpu-firmware-amd-kmod-vcn-4-0-0"
+                       addpkg "gpu-firmware-amd-kmod-dcn-3-2-0 \
+                               gpu-firmware-amd-kmod-gc-11-0-0 \
+                               gpu-firmware-amd-kmod-psp-13-0-0 \
+                               gpu-firmware-amd-kmod-smu-13-0-0 \
+                               gpu-firmware-amd-kmod-sdma-6-0-0 \
+                               gpu-firmware-amd-kmod-vcn-4-0-0"
                        ;;
        esac
 }

Ok I see, then sorry to ask this but the first version (with multiple call to addpkg) is prettier, can you update again ? :)

[manu]

Thanks.