libhtr: pthread_attr_setaffinity_np(): Replace calloc() with malloc()
ClosedPublic
Actions

Authored by olce on Jan 5 2024, 2:18 PM.

Details

Reviewers

kib
emaste

Commits

rG2c9ab16625d7: libhtr: pthread_attr_setaffinity_np(): Replace calloc() with malloc()
rG194df67ef569: libhtr: pthread_attr_setaffinity_np(): Replace calloc() with malloc()
rG15bb0300eeca: libhtr: pthread_attr_setaffinity_np(): Replace calloc() with malloc()

Summary

Using calloc() instead of malloc() is useless here since the allocated
memory is to be wholly crushed by the memcpy() call that follows.

Suggested by: kib
MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olce created this revision.Jan 5 2024, 2:18 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 5 2024, 2:18 PM

olce requested review of this revision.Jan 5 2024, 2:18 PM

Harbormaster completed remote builds in B55258: Diff 132336.Jan 5 2024, 2:18 PM

olce added a parent revision: D43327: libthr: thr_attr.c: More style and clarity fixes.Jan 5 2024, 2:18 PM

olce added a child revision: D43329: pthread_attr_get_np(): Use malloc(), report ENOMEM, don't tamper on error.

emaste accepted this revision.Jan 5 2024, 2:57 PM

This revision is now accepted and ready to land.Jan 5 2024, 2:57 PM

kib accepted this revision.Jan 5 2024, 4:05 PM

The typo in the title ("libhtr" => "libthr") will be fixed on commit.

Approved

Closed by commit rG15bb0300eeca: libhtr: pthread_attr_setaffinity_np(): Replace calloc() with malloc() (authored by olce). · Explain WhyJan 9 2024, 1:32 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rG15bb0300eeca: libhtr: pthread_attr_setaffinity_np(): Replace calloc() with malloc().

olce added a commit: rG194df67ef569: libhtr: pthread_attr_setaffinity_np(): Replace calloc() with malloc().Jan 26 2024, 9:04 PM

olce added a commit: rG2c9ab16625d7: libhtr: pthread_attr_setaffinity_np(): Replace calloc() with malloc().

Revision Contents
Changeset List

Path

Size

lib/

libthr/

thread/

thr_attr.c

2 lines

Diff 132493

View Options

lib/libthr/thread/thr_attr.c

libhtr: pthread_attr_setaffinity_np(): Replace calloc() with malloc()ClosedPublicActions