Convert fsidcmp(9) from macro to inline function
ClosedPublic
Actions

Authored by kib on Dec 27 2023, 2:51 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Oct 1, 1:09 AM

	Unknown Object (File)
	Aug 30 2025, 5:37 AM

	Unknown Object (File)
	Aug 23 2025, 5:07 PM

	Unknown Object (File)
	Aug 12 2025, 9:23 AM

	Unknown Object (File)
	Aug 9 2025, 6:15 AM

	Unknown Object (File)
	Jul 28 2025, 6:38 PM

	Unknown Object (File)
	Jul 27 2025, 12:00 PM

	Unknown Object (File)
	Jul 26 2025, 10:43 PM

View All 82 Files

Subscribers

imp

Details

Reviewers

zlei
markj

Commits

rG3334a537ed38: Convert fsidcmp(9) from macro to inline function

Summary

This allows type checking the arguments.

Explicit structure members comparisions are done to avoid introducting
string.h pollution for userspace.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Dec 27 2023, 2:51 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 27 2023, 2:51 AM

kib requested review of this revision.Dec 27 2023, 2:51 AM

markj added inline comments.Dec 27 2023, 3:27 AM

sys/sys/mount.h
57

Fix silliness.

markj accepted this revision.Dec 27 2023, 3:58 AM

This revision is now accepted and ready to land.Dec 27 2023, 3:58 AM

Closed by commit rG3334a537ed38: Convert fsidcmp(9) from macro to inline function (authored by kib). · Explain WhyDec 27 2023, 10:05 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG3334a537ed38: Convert fsidcmp(9) from macro to inline function.

Revision Contents
Changeset List

Path

Size

sys/

mount.h

7 lines

Diff 131900

View Options

Convert fsidcmp(9) from macro to inline functionClosedPublicActions