Convert fsidcmp(9) from macro to inline function
ClosedPublic
Actions

Authored by kib on Dec 27 2023, 2:51 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Mar 29, 9:13 PM

	Unknown Object (File)
	Wed, Mar 25, 11:45 PM

	Unknown Object (File)
	Wed, Mar 25, 4:43 PM

	Unknown Object (File)
	Wed, Mar 25, 12:49 PM

	Unknown Object (File)
	Thu, Mar 19, 5:37 AM

	Unknown Object (File)
	Thu, Mar 19, 5:37 AM

	Unknown Object (File)
	Wed, Mar 18, 8:16 AM

	Unknown Object (File)
	Wed, Mar 18, 8:09 AM

View All Files

Subscribers

imp

Details

Reviewers

zlei
markj

Commits

rG3334a537ed38: Convert fsidcmp(9) from macro to inline function

Summary

This allows type checking the arguments.

Explicit structure members comparisions are done to avoid introducting
string.h pollution for userspace.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Dec 27 2023, 2:51 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 27 2023, 2:51 AM

kib requested review of this revision.Dec 27 2023, 2:51 AM

markj added inline comments.Dec 27 2023, 3:27 AM

sys/sys/mount.h
57

Fix silliness.

markj accepted this revision.Dec 27 2023, 3:58 AM

This revision is now accepted and ready to land.Dec 27 2023, 3:58 AM

Closed by commit rG3334a537ed38: Convert fsidcmp(9) from macro to inline function (authored by kib). · Explain WhyDec 27 2023, 10:05 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG3334a537ed38: Convert fsidcmp(9) from macro to inline function.

Revision Contents
Changeset List

Path

Size

sys/

mount.h

7 lines

Diff 131893

View Options

Convert fsidcmp(9) from macro to inline functionClosedPublicActions