kldxref: Simplify elf_read_raw_data
ClosedPublic
Actions

Authored by jhb on Dec 19 2023, 8:15 PM.

Details

Reviewers

jrtc27
imp

Commits

rGea717376822e: kldxref: Simplify elf_read_raw_data
rG38effbdd2d8a: kldxref: Simplify elf_read_raw_data
rGed96fd7fc652: kldxref: Simplify elf_read_raw_data

Summary

Use pread as a valid offset is always passed now. Originally the DSO
code read the .hash section in two separate requests and relied on the
implicit offset for the second read, but now the hash table is fetched
in a single call.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Dec 19 2023, 8:15 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 19 2023, 8:15 PM

jhb requested review of this revision.Dec 19 2023, 8:15 PM

Harbormaster completed remote builds in B55035: Diff 131592.Dec 19 2023, 8:15 PM

jhb added a parent revision: D43124: kldxref: Tidy error handling for invalid addresses.Dec 19 2023, 8:15 PM

jhb added a child revision: D43126: kldxref: Simplify handling of ELF object files.

imp accepted this revision.Dec 21 2023, 11:12 PM

This revision is now accepted and ready to land.Dec 21 2023, 11:12 PM

Closed by commit rGed96fd7fc652: kldxref: Simplify elf_read_raw_data (authored by jhb). · Explain WhyDec 22 2023, 3:50 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGed96fd7fc652: kldxref: Simplify elf_read_raw_data.

jhb added a commit: rG38effbdd2d8a: kldxref: Simplify elf_read_raw_data.Jan 18 2024, 10:26 PM

jhb added a commit: rGea717376822e: kldxref: Simplify elf_read_raw_data.Jan 18 2024, 10:33 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

kldxref/

elf.c

6 lines

Diff 131732

View Options

usr.sbin/kldxref/elf.c

This file was added.

				# $FreeBSD$
				.PATH: ${SRCTOP}/sys/dev/safexcel

				KMOD= safexcel
				SRCS= safexcel.c

				SRCS+= bus_if.h cryptodev_if.h device_if.h

				andrewUnsubmitted Done Inline Actions You also need `ofw_bus_if.h` here as it's included from `ofw_bus.h` and `ofw_bus_subr.h` andrew: You also need `ofw_bus_if.h` here as it's included from `ofw_bus.h` and `ofw_bus_subr.h`
				.include <bsd.kmod.mk>

kldxref: Simplify elf_read_raw_dataClosedPublicActions