Differential D43124

kldxref: Tidy error handling for invalid addresses
ClosedPublic
Actions

Authored by jhb on Dec 19 2023, 8:15 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 8, 5:12 AM

	Unknown Object (File)
	Sun, Feb 8, 2:30 AM

	Unknown Object (File)
	Sat, Jan 31, 12:31 PM

	Unknown Object (File)
	Dec 26 2025, 1:15 PM

	Unknown Object (File)
	Dec 21 2025, 1:40 AM

	Unknown Object (File)
	Dec 12 2025, 2:41 AM

	Unknown Object (File)
	Nov 11 2025, 2:08 AM

	Unknown Object (File)
	Nov 7 2025, 2:08 AM

View All 100 Files

Subscribers

Details

Reviewers

jrtc27
imp

Commits

rGf7e181afba92: kldxref: Tidy error handling for invalid addresses
rG6de6c4211bdd: kldxref: Tidy error handling for invalid addresses
rG6d46e2e0a7f3: kldxref: Tidy error handling for invalid addresses

Summary

Don't print an offset value that's always zero.

ef_get_offset can't return -1.

Sponsored by: DARPA

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Dec 19 2023, 8:15 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 19 2023, 8:15 PM

jhb requested review of this revision.Dec 19 2023, 8:15 PM

Harbormaster completed remote builds in B55034: Diff 131591.Dec 19 2023, 8:15 PM

jhb added a child revision: D43125: kldxref: Simplify elf_read_raw_data.Dec 19 2023, 8:15 PM

imp accepted this revision.Dec 21 2023, 11:12 PM

This revision is now accepted and ready to land.Dec 21 2023, 11:12 PM

Closed by commit rG6d46e2e0a7f3: kldxref: Tidy error handling for invalid addresses (authored by jhb). · Explain WhyDec 22 2023, 3:50 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG6d46e2e0a7f3: kldxref: Tidy error handling for invalid addresses.

jhb added a commit: rG6de6c4211bdd: kldxref: Tidy error handling for invalid addresses.Jan 18 2024, 10:26 PM

jhb added a commit: rGf7e181afba92: kldxref: Tidy error handling for invalid addresses.

Revision Contents
Changeset List

Path

Size

usr.sbin/

kldxref/

6 lines

Diff 131731

usr.sbin/kldxref/ef.c

Loading...