{amd64,i386}/SYS.h: add _SYSCALL and _SYSCALL_BODY
ClosedPublic
Actions

Authored by brooks on Dec 14 2023, 1:21 AM.

Details

Reviewers

imp
jhb
markj

Commits

rG8f465f509bc1: {amd64,i386}/SYS.h: add _SYSCALL and _SYSCALL_BODY

Summary

Add a _SYSCALL(name) which calls the SYS_name syscall. Use it to add a
_SYSCALL_BODY() macro which invokes the syscall and calls cerror as
required. Use the latter to implement PSEUDO() and RSYSCALL().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks requested review of this revision.Dec 14 2023, 1:21 AM

brooks created this revision.

Harbormaster completed remote builds in B54944: Diff 131428.Dec 14 2023, 1:21 AM

This is part of a set of changes I've posted at https://github.com/brooksdavis/freebsd/tree/SYS.h-unification. I've done basic smoke testing of amd64 under qemu, i386 might need more testing.

imp accepted this revision.Dec 14 2023, 1:31 AM

This revision is now accepted and ready to land.Dec 14 2023, 1:31 AM

markj added inline comments.Dec 14 2023, 3:02 PM

lib/libc/amd64/SYS.h
39
45	We're inconsistent about whether the macro ends with a semicolon. It would also be more consistent to keep one instruction per line.
lib/libc/i386/SYS.h
39