Page MenuHomeFreeBSD
Differential D43083

bsd-spell: Install as bspell instead of spell
ClosedPublic
Actions

Authored by gbe on Dec 17 2023, 3:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 30 2024, 1:55 PM
Unknown Object (File)
Sep 26 2024, 7:01 PM
Unknown Object (File)
Sep 23 2024, 6:33 PM
Unknown Object (File)
Sep 23 2024, 11:42 AM
Unknown Object (File)
Sep 4 2024, 9:55 PM
Unknown Object (File)
Aug 31 2024, 4:24 PM
Unknown Object (File)
Aug 20 2024, 7:53 PM
Unknown Object (File)
Aug 19 2024, 9:18 AM
View All 42 Files
Subscribers
fernape

Details

Reviewers
grahamperrin
fernape
Group Reviewers
Ports Committers
Commits
R11:bb1f23aa2db1: bsd-spell: Install as bspell instead of spell
Summary

Install bsd-spell as bspell instead of spell since it otherwise
conflicts with textproc/aspell-ispell.

PR: 274217

Test Plan

make in the textproc/bsd-spell directory

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 54988
Build 51877: arc lint + arc unit

Event Timeline

gbe requested review of this revision.Dec 17 2023, 3:38 PM
gbe created this revision.
Harbormaster completed remote builds in B54982: Diff 131507.Dec 17 2023, 3:38 PM
gbe added reviewers: Ports Committers, grahamperrin.Dec 17 2023, 3:38 PM
fernape requested changes to this revision.Dec 18 2023, 6:25 PM
fernape added a subscriber: fernape.

This needs bumping PORTREVISION

This revision now requires changes to proceed.Dec 18 2023, 6:25 PM
gbe updated this revision to Diff 131525.Dec 18 2023, 7:09 PM
  • Add PORTREVISION for bsd-spell
Harbormaster completed remote builds in B54987: Diff 131525.Dec 18 2023, 7:09 PM
gbe added a comment.Dec 18 2023, 7:10 PM
In D43083#982282, @fernape wrote:

This needs bumping PORTREVISION

The port hasn't a PORTREVISION, yet. I added one and set it to one.

fernape added inline comments.Dec 18 2023, 7:16 PM
textproc/bsd-spell/Makefile
17–18

bin/spell needs to be bin/bspell too, otherwise this fails to package.
Also, put one file per line. It is easier to read (although with 7 entries I would use pkg-plist which is easier to grep.

gbe updated this revision to Diff 131527.Dec 18 2023, 7:25 PM
  • Switch the port to use pkg-plist
Harbormaster completed remote builds in B54988: Diff 131527.Dec 18 2023, 7:25 PM
gbe marked an inline comment as done.Dec 18 2023, 7:26 PM

Address comments.

fernape accepted this revision.Dec 18 2023, 7:33 PM

LGTM.

Builds without problems.
Installs along aspell-ispell without conflicts.

Thanks for the changes!

This revision is now accepted and ready to land.Dec 18 2023, 7:33 PM
Closed by commit R11:bb1f23aa2db1: bsd-spell: Install as bspell instead of spell (authored by gbe). · Explain WhyDec 19 2023, 11:40 AM
This revision was automatically updated to reflect the committed changes.
gbe added a commit: R11:bb1f23aa2db1: bsd-spell: Install as bspell instead of spell.

Revision Contents
Changeset List

PathSize
textproc/
bsd-spell/
11 lines
10 lines

Diff 131527

View Options

textproc/bsd-spell/Makefile

Loading...
View Options

textproc/bsd-spell/pkg-plist

Loading...