Page MenuHomeFreeBSD
Differential D43061

arm/SYS.h: align with other arches
ClosedPublic
Actions

Authored by brooks on Dec 14 2023, 1:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 1, 2:53 AM
Unknown Object (File)
Mon, Sep 28, 5:49 AM
Unknown Object (File)
Thu, Sep 17, 7:46 AM
Unknown Object (File)
Wed, Sep 16, 6:59 AM
Unknown Object (File)
Mon, Sep 14, 5:46 AM
Unknown Object (File)
Sat, Sep 12, 10:44 AM
Unknown Object (File)
Sat, Sep 12, 5:55 AM
Unknown Object (File)
Thu, Sep 10, 10:25 PM
View All Files
Subscribers
None

Details

Reviewers
imp
manu
andrew
Commits
rG8a1b84f861e8: arm/SYS.h: align with other arches
Summary

Rename SYSTRAP() macro to _SYSCALL() and add _SYSCALL_BODY() which invokes
the syscall via _SYCALL() and then calls cerror as required. Use to
implement PSEUDO() and RSYSCALL() removing _SYSCALL_NOERROR().

Sponsored by: DARPA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 54946
Build 51835: arc lint + arc unit

Event Timeline

brooks created this revision.Dec 14 2023, 1:22 AM
Herald added a reviewer: andrew. · View Herald TranscriptDec 14 2023, 1:22 AM
brooks requested review of this revision.Dec 14 2023, 1:22 AM
brooks added a parent revision: D43060: arm/SYS.h: remove unused CURBRK macro.
Harbormaster completed remote builds in B54946: Diff 131430.Dec 14 2023, 1:22 AM
brooks added a comment.Dec 14 2023, 1:23 AM

This is part of a set of changes I've posted at https://github.com/brooksdavis/freebsd/tree/SYS.h-unification. This compiles but I've not been able to test it.

brooks added a comment.EditedDec 14 2023, 1:26 AM

With this change, arm is still the odd one out with all the __CONCAT() use, but it's much more closely aligned than before.

imp accepted this revision.Dec 14 2023, 1:32 AM
This revision is now accepted and ready to land.Dec 14 2023, 1:32 AM
brooks added a comment.Dec 14 2023, 11:35 PM

I've done basic smoke testing of this patch in a jail on an aarch64 system

Closed by commit rG8a1b84f861e8: arm/SYS.h: align with other arches (authored by brooks). · Explain WhyDec 18 2023, 10:29 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rG8a1b84f861e8: arm/SYS.h: align with other arches.

Revision Contents
Changeset List

PathSize
lib/
libc/
arm/
30 lines
sys/
2 lines

Diff 131430

View Options

lib/libc/arm/SYS.h

Loading...
View Options

lib/libc/arm/sys/vfork.S

Loading...