Implement -P for boot loader.
ClosedPublic
Actions

Authored by imp on Feb 7 2016, 5:38 AM.

Details

Reviewers

emaste
allanjude
smh

Commits

rS295408: Implement -P for boot loader. It's a bit easier to implement here than

Summary

It's a bit easier to implement here than in boot1, like is normally
done. When a keyboard appears in the UEFI device tree, assume -D -h,
just like on a BIOS boot.

It is unclear if an ACPI keyboard appearing in the tree means there's
a real keyboard or not. A USB keyboard doesn't seem to appear unless
it is really there.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp updated this revision to Diff 13102.Feb 7 2016, 5:38 AM

imp retitled this revision from to Implement -P for boot loader..

imp updated this object.

imp edited the test plan for this revision. (Show Details)

imp added reviewers: emaste, smh, allanjude.Feb 7 2016, 5:40 AM

allanjude added inline comments.Feb 7 2016, 6:12 AM

sys/boot/efi/loader/main.c
108 ↗	(On Diff #13102)	typo (handles)
125 ↗	(On Diff #13102)	typo (each)

Looks good to me (did not review the has_keboard implementation in minute detail).

sys/boot/efi/loader/main.c
153 ↗	(On Diff #13102)	This comment seems incomplete, or partially redundant.

This revision is now accepted and ready to land.Feb 8 2016, 7:27 PM

Closed by commit rS295408: Implement -P for boot loader. It's a bit easier to implement here than (authored by imp). · Explain WhyFeb 8 2016, 7:34 PM

This revision was automatically updated to reflect the committed changes.

smh added inline comments.Feb 8 2016, 10:59 PM

head/sys/boot/efi/loader/main.c
116	looks like an unrequired wrap given the lines above / below.
119	You could also return here.
122	style(9) missing braces.
130	The following is simpler to understand IMO: nhandles = sz / sizeof(hin); for (i = 0; i < nhandles; i++) { status = BS->HandleProtocol(hin[i], &devid, (VOID *)&path);
140	typo? "unclear if there's" ?
144	You could use IsDevicePathType here.
150	What are these magic constants and can we get some defines for them, so they aren't?
160	As above, but might be nice to also introduce an IsDevicePathSubType too.
177	style(9) brace return value
202	BOOL ?
249	style(9) int is not a bool.

Revision Contents
Changeset List

Path

Size

head/

sys/

boot/

efi/

loader/

main.c

96 lines

Diff 13132

View Options

head/sys/boot/efi/loader/main.c

Implement -P for boot loader.ClosedPublicActions