Page MenuHomeFreeBSD
Differential D42837

smbus: add compat32 support for SMB ioctls
ClosedPublic
Actions

Authored by stevek on Nov 29 2023, 7:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 19, 6:53 PM
Unknown Object (File)
Sun, Jul 5, 6:28 AM
Unknown Object (File)
Sat, Jul 4, 7:12 PM
Unknown Object (File)
Sat, Jul 4, 6:20 AM
Unknown Object (File)
Sat, Jul 4, 2:08 AM
Unknown Object (File)
Fri, Jul 3, 10:11 AM
Unknown Object (File)
Thu, Jul 2, 10:47 PM
Unknown Object (File)
Thu, Jul 2, 3:07 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
jhb
Commits
rG376330aca184: smbus: add compat32 support for SMB ioctls
Summary

Some of the SMB ioctl request structures contain pointers and need to
handle requests from 32-bit applications on 64-bit kernels.

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 54693
Build 51582: arc lint + arc unit

Event Timeline

stevek created this revision.Nov 29 2023, 7:35 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 29 2023, 7:35 PM
stevek requested review of this revision.Nov 29 2023, 7:35 PM
Harbormaster completed remote builds in B54693: Diff 130810.Nov 29 2023, 7:35 PM
stevek added reviewers: kib, jhb.Nov 29 2023, 7:37 PM
jhb accepted this revision.Nov 29 2023, 8:58 PM
This revision is now accepted and ready to land.Nov 29 2023, 8:58 PM
kib added inline comments.Nov 29 2023, 9:07 PM
sys/dev/smbus/smb.c
253

Could any of these calls sleep?

kib accepted this revision.Nov 29 2023, 9:42 PM
kib added inline comments.
sys/dev/smbus/smb.c
253

Ignore the question, it is not worse than the current situation due to small data optimization in kern_ioctl().

Closed by commit rG376330aca184: smbus: add compat32 support for SMB ioctls (authored by stevek). · Explain WhyNov 29 2023, 11:16 PM
This revision was automatically updated to reflect the committed changes.
stevek added a commit: rG376330aca184: smbus: add compat32 support for SMB ioctls.

Revision Contents
Changeset List

PathSize
sys/
dev/
smbus/
142 lines

Diff 130810

View Options

sys/dev/smbus/smb.c

Loading...