devd: autofs: Move autofs related events to a separate file
ClosedPublic
Actions

Authored by manu on Nov 7 2023, 3:42 PM.

Details

Reviewers

trasz
imp

Commits

rG32fdac77b3d7: devd: autofs: Move autofs related events to a separate file
rGb3c116d50eca: devd: autofs: Move autofs related events to a separate file

Summary

If a user don't have FreeBSD-autofs installed there is no need to try calling
automount on every GEOM event.
It's also easier to add/delete autofs related event in a separate file.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 54320
Build 51210: arc lint + arc unit

Event Timeline

manu created this revision.Nov 7 2023, 3:42 PM

Herald added subscribers: asomers, imp. · View Herald TranscriptNov 7 2023, 3:42 PM

manu requested review of this revision.Nov 7 2023, 3:42 PM

Harbormaster completed remote builds in B54320: Diff 129821.Nov 7 2023, 3:42 PM

manu added a parent revision: D42494: autofs: media: Always use sync option for fat*.Nov 7 2023, 3:42 PM

manu added a reviewer: trasz.

imp accepted this revision.Nov 7 2023, 3:56 PM

This revision is now accepted and ready to land.Nov 7 2023, 3:56 PM

Doesn't this also enable it by default? If so, it might be a good idea to fix the instapanic it's causing first, https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274992.

In D42495#970321, @trasz wrote:

Doesn't this also enable it by default? If so, it might be a good idea to fix the instapanic it's causing first, https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274992.

It's already enabled, also can't reproduce your panic (I'm running GENERIC-NODEBUG at 2fee3974603bce6f2dc153eb6af459cb4f864ab4)

Closed by commit rGb3c116d50eca: devd: autofs: Move autofs related events to a separate file (authored by manu). · Explain WhyNov 24 2023, 9:46 AM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rGb3c116d50eca: devd: autofs: Move autofs related events to a separate file.

manu added a commit: rG32fdac77b3d7: devd: autofs: Move autofs related events to a separate file.Jun 4 2024, 11:37 AM