Page MenuHomeFreeBSD
Differential D42433

ino64: Fix incremental builds
ClosedPublic
Actions

Authored by imp on Nov 1 2023, 6:00 PM.
Tags
None
Referenced Files
F87335015: D42433.id129597.diff
Mon, Jul 1, 8:46 PM
F87334842: D42433.id129653.diff
Mon, Jul 1, 8:44 PM
Unknown Object (File)
Sun, Jun 30, 11:09 AM
Unknown Object (File)
Sat, Jun 29, 6:10 PM
Unknown Object (File)
Sat, Jun 29, 7:43 AM
Unknown Object (File)
Wed, Jun 26, 5:01 PM
Unknown Object (File)
Sun, Jun 23, 3:51 AM
Unknown Object (File)
May 27 2024, 10:12 AM
View All 28 Files
Subscribers
khorben_defora.org

Details

Reviewers
bapt
emaste
khorben_defora.org
Commits
rG2d8fabef75db: ino64: Fix incremental builds
Summary

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 54239
Build 51129: arc lint + arc unit

Event Timeline

imp requested review of this revision.Nov 1 2023, 6:00 PM
imp created this revision.
Harbormaster completed remote builds in B54239: Diff 129597.Nov 1 2023, 6:00 PM
emaste added inline comments.Nov 1 2023, 6:45 PM
tools/build/depend-cleanup.sh
214

xxxx?

emaste added a comment.Nov 1 2023, 6:51 PM

"c" entries look good, I don't think compat-ino64 h is needed, and comment needs a hash reference

tools/build/depend-cleanup.sh
215

I think this is unnecessary? There is no compat-ino64.o

imp updated this revision to Diff 129653.Nov 2 2023, 5:16 PM

remove /sys

Harbormaster completed remote builds in B54257: Diff 129653.Nov 2 2023, 5:16 PM
khorben_defora.org added a subscriber: khorben_defora.org.Nov 2 2023, 5:37 PM
In D42433#968563, @imp wrote:

remove /sys

It works for me without the /sys.

emaste added a comment.Nov 2 2023, 5:40 PM

LGTM assuming the hash is inserted (and presumably compat-ino64.h removed)

emaste added a reviewer: khorben_defora.org.Nov 2 2023, 5:57 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 2 2023, 6:09 PM
Closed by commit rG2d8fabef75db: ino64: Fix incremental builds (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG2d8fabef75db: ino64: Fix incremental builds.

Revision Contents
Changeset List

PathSize
tools/
build/
9 lines

Diff 129597

View Options

tools/build/depend-cleanup.sh

Loading...