Differential D5156

Delete argsize to fix a -Wunused-but-set-variable warning with gcc 4.9
ClosedPublic
Actions

Authored by ngie on Feb 1 2016, 7:21 AM.

Details

Reviewers

delphij

Commits

rS295121: Delete argsize to fix a -Wunused-but-set-variable warning with gcc 4.9

Summary

Delete argsize to fix a -Wunused-but-set-variable warning with gcc 4.9

The variable isn't actually checked -- just the end result which gets returned
from the function

MFC after: 1 month
Sponsored by: EMC / Isilon Storage Division

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ngie updated this revision to Diff 12922.Feb 1 2016, 7:21 AM

ngie retitled this revision from to Delete argsize to fix a -Wunused-but-set-variable warning with gcc 4.9.

ngie updated this object.

ngie edited the test plan for this revision. (Show Details)

ngie added a reviewer: delphij.

ngie added a subscriber: araujo.

Herald added a subscriber: imp. · View Herald TranscriptFeb 1 2016, 7:21 AM

Not sure about this change, because if asprintf() can't allocate sufficient memory it will return -1. Maybe a (void)asprintf(.....) could be better. I guess that int is there to silent the -1 return.

I've no idea what I was thinking about :-/ but your change is good.

This revision is now accepted and ready to land.Feb 1 2016, 7:57 AM

In D5156#109662, @araujo wrote:

Not sure about this change, because if asprintf() can't allocate sufficient memory it will return -1. Maybe a (void)asprintf(.....) could be better. I guess that int is there to silent the -1 return.

I'll add (void) for clarity -- thanks for the feedback :).

Closed by commit rS295121: Delete argsize to fix a -Wunused-but-set-variable warning with gcc 4.9 (authored by ngie). · Explain WhyFeb 1 2016, 8:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sbin/

swapon/

swapon.c

4 lines

Diff 12924

View Options

Delete argsize to fix a -Wunused-but-set-variable warning with gcc 4.9ClosedPublicActions