Paths

Table of Contentst

Differential D41980

lib/libc/amd64/string: implement strpbrk() through strcspn()
ClosedPublic
Actions

Authored by fuz on Sep 25 2023, 9:49 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 15, 6:42 PM

	Unknown Object (File)
	Fri, May 15, 6:42 PM

	Unknown Object (File)
	Fri, May 15, 6:22 PM

	Unknown Object (File)
	Mon, May 11, 11:50 PM

	Unknown Object (File)
	Sun, May 10, 5:55 PM

	Unknown Object (File)
	Sat, May 9, 1:42 AM

	Unknown Object (File)
	Fri, May 8, 4:32 PM

	Unknown Object (File)
	May 7 2026, 8:18 AM

Subscribers

Details

Reviewers

mjg
kib

Commits

rGf42eca44bdfb: share/man/man7/simd.7: document amd64 SIMD use for strpbrk()
rG309b30ce8419: lib/libc/amd64/string: implement strpbrk() through strcspn()
rG8b60e1fdbefa: share/man/man7/simd.7: document amd64 SIMD use for strpbrk()
rGf4fc317c364f: lib/libc/amd64/string: implement strpbrk() through strcspn()

Summary

This lets us use our optimised strcspn() routine for strpbrk() calls.

In principle, this change could be applied to all architectures
through modification of lib/libc/string/strpbrk.c as strcspn
has a better generic implementation than strpbrk. I have avoided
this as to reduce the impact of these changes. If desired I can
update this DR to do so.

Sponsored by: The FreeBSD Foundation

Test Plan

passes test suite

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 53721
Build 50612: arc lint + arc unit

Event Timeline

fuz created this revision.Sep 25 2023, 9:49 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 25 2023, 9:49 PM

fuz requested review of this revision.Sep 25 2023, 9:49 PM

Harbormaster completed remote builds in B53721: Diff 127807.Sep 25 2023, 9:49 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 25 2023, 2:26 PM

Closed by commit rGf4fc317c364f: lib/libc/amd64/string: implement strpbrk() through strcspn() (authored by fuz). · Explain Why

This revision was automatically updated to reflect the committed changes.

fuz added a commit: rGf4fc317c364f: lib/libc/amd64/string: implement strpbrk() through strcspn().

fuz added a commit: rG8b60e1fdbefa: share/man/man7/simd.7: document amd64 SIMD use for strpbrk().

fuz added a commit: rG309b30ce8419: lib/libc/amd64/string: implement strpbrk() through strcspn().Jan 24 2024, 7:45 PM

fuz added a commit: rGf42eca44bdfb: share/man/man7/simd.7: document amd64 SIMD use for strpbrk().

Revision Contents
Changeset List

Path

Size

lib/

libc/

amd64/

string/

1 line

18 lines

43 lines

share/

man/

man7/

1 line

Diff 127807

lib/libc/amd64/string/Makefile.inc

Loading...

lib/libc/amd64/string/strcspn.S

Loading...

lib/libc/amd64/string/strpbrk.c

Loading...

share/man/man7/simd.7

Loading...