Page MenuHomeFreeBSD
Differential D30557

x11/xtrans: don't unlink existing UNIX sockets
ClosedPublic
Actions

Authored by jbeich on May 30 2021, 9:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 4:46 AM
Unknown Object (File)
Thu, Dec 5, 7:54 AM
Unknown Object (File)
Thu, Dec 5, 7:52 AM
Unknown Object (File)
Mon, Nov 25, 5:02 PM
Unknown Object (File)
Mon, Nov 25, 5:19 AM
Unknown Object (File)
Mon, Nov 25, 5:19 AM
Unknown Object (File)
Mon, Nov 25, 5:19 AM
Unknown Object (File)
Mon, Nov 25, 5:19 AM
View All Files
Subscribers
arrowd
manu
zeising

Details

Reviewers
manu
Group Reviewers
x11
Commits
R11:3312d027696f: x11/xtrans: Don't unlink X11 Unix sockets.
Summary

Prevents multiple Xorg/Xwayland/Xephyr/etc instances from trampling each other X11 sockets (e.g., /tmp/.X11-unix/X0) that maybe still in use.

PR: 253277
Submitted by: Olivier Certner (based on)

Test Plan

Builds OK:

  • 11.4/12.2/13.0/14.0 aarch64/amd64/i386/armv6/armv7
  • All 19 consumers (via freshports list)

Runtime OK:

  • Xwayland (via sway)
  • Xorg (via startx)

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jbeich requested review of this revision.May 30 2021, 9:25 PM
jbeich created this revision.
jbeich updated this revision to Diff 90140.May 30 2021, 9:39 PM
jbeich edited the summary of this revision. (Show Details)
  • Deduplicate PORTREVISION bumps
zeising added a subscriber: zeising.May 31 2021, 6:29 AM

I would like upstream to at least comment on the MR before we merge it into the FreeBSD ports tree.

manu requested changes to this revision.Jul 22 2021, 4:26 PM
manu added a subscriber: manu.

Mark as request changes so it doesn't shows up in phab in "Must Review" category.

This revision now requires changes to proceed.Jul 22 2021, 4:26 PM
arrowd added a subscriber: arrowd.Sep 1 2023, 8:23 AM

I have implemented all necessary stuff on the ConsoleKit and SDDM side to make switching users possible. This change is the last piece of puzzle.

manu accepted this revision.Sep 1 2023, 8:56 AM
In D30557#950012, @arrowd wrote:

I have implemented all necessary stuff on the ConsoleKit and SDDM side to make switching users possible. This change is the last piece of puzzle.

Go ahead.

This revision is now accepted and ready to land.Sep 1 2023, 8:56 AM
Closed by commit R11:3312d027696f: x11/xtrans: Don't unlink X11 Unix sockets. (authored by arrowd). · Explain WhySep 1 2023, 11:49 AM
This revision was automatically updated to reflect the committed changes.
arrowd added a commit: R11:3312d027696f: x11/xtrans: Don't unlink X11 Unix sockets..
jbeich mentioned this in R11:5a79b86ff2ad: x11-servers/xwayland: rebuild after 3312d027696f.Sep 1 2023, 3:04 PM

Revision Contents
Changeset List

PathSize
net/
tigervnc-server/
2 lines
x11-fonts/
libFS/
1 line
libXfont/
2 lines
libXfont2/
1 line
xfs/
1 line
x11-servers/
xarcan/
2 lines
xorg-server/
2 lines
xwayland-devel/
1 line
x11/
cinnamon-session/
2 lines
gnome-session/
2 lines
libICE/
2 lines
libSM/
1 line
libX11/
1 line
mate-session-manager/
2 lines
xtrans/
4 lines
2 lines

Diff 126789

View Options

net/tigervnc-server/Makefile

Loading...
View Options

x11-fonts/libFS/Makefile

Loading...
View Options

x11-fonts/libXfont/Makefile

Loading...
View Options

x11-fonts/libXfont2/Makefile

Loading...
View Options

x11-fonts/xfs/Makefile

Loading...
View Options

x11-servers/xarcan/Makefile

Loading...
View Options

x11-servers/xorg-server/Makefile

Loading...
View Options

x11-servers/xwayland-devel/Makefile

Loading...
View Options

x11/cinnamon-session/Makefile

Loading...
View Options

x11/gnome-session/Makefile

Loading...
View Options

x11/libICE/Makefile

Loading...
View Options

x11/libSM/Makefile

Loading...
View Options

x11/libX11/Makefile

Loading...
View Options

x11/mate-session-manager/Makefile

Loading...
View Options

x11/xtrans/Makefile

Loading...
View Options

x11/xtrans/distinfo

Loading...