Page MenuHomeFreeBSD
Differential D5063

libthr for RISC-V
ClosedPublic
Actions

Authored by br on Jan 25 2016, 10:49 AM.
Tags
None
Referenced Files
F108388592: D5063.diff
Fri, Jan 24, 9:36 AM
Unknown Object (File)
Sat, Jan 18, 11:07 AM
Unknown Object (File)
Dec 24 2024, 3:18 AM
Unknown Object (File)
Dec 7 2024, 7:36 PM
Unknown Object (File)
Dec 7 2024, 7:36 PM
Unknown Object (File)
Dec 7 2024, 7:36 PM
Unknown Object (File)
Dec 7 2024, 7:36 PM
Unknown Object (File)
Dec 7 2024, 7:07 PM
View All Files
Subscribers
None

Details

Reviewers
emaste
andrew
Commits
rS294912: Add pthread MD part for RISC-V.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br updated this revision to Diff 12678.Jan 25 2016, 10:49 AM
br retitled this revision from to libthr for RISC-V.
br updated this object.
br edited the test plan for this revision. (Show Details)
br added reviewers: andrew, emaste.
andrew added inline comments.Jan 25 2016, 11:52 AM
lib/libthr/arch/riscv/include/pthread_md.h
64

Why + 0x10?

br updated this revision to Diff 12682.Jan 25 2016, 2:03 PM

unmagic 0x10, which is TP_OFFSET

br marked an inline comment as done.Jan 25 2016, 2:03 PM
br added inline comments.
lib/libthr/arch/riscv/include/pthread_md.h
66

it is TP_OFFSET (architecture specific)

andrew added inline comments.Jan 25 2016, 2:40 PM
lib/libthr/arch/riscv/include/pthread_md.h
66

Why is it needed? rtld-elf already takes the size of struct tcb into account.

br marked an inline comment as done.Jan 25 2016, 3:38 PM
br added inline comments.
lib/libthr/arch/riscv/include/pthread_md.h
66

So compiler expects that tp register points to the first static TLS block. In variant I it is located just after struct tcb.
We do the same in lib/libc/riscv/gen/_set_tp.c

Closed by commit rS294912: Add pthread MD part for RISC-V. (authored by br). · Explain WhyJan 27 2016, 2:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
lib/
libthr/
arch/
riscv/
include/
91 lines

Diff 12678

View Options

lib/libthr/arch/riscv/include/pthread_md.h

Loading...