libthr for RISC-V
ClosedPublic
Actions

Authored by br on Jan 25 2016, 10:49 AM.

Details

Reviewers

emaste
andrew

Commits

rS294912: Add pthread MD part for RISC-V.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

br updated this revision to Diff 12678.Jan 25 2016, 10:49 AM

br retitled this revision from to libthr for RISC-V.

br updated this object.

br edited the test plan for this revision. (Show Details)

br added reviewers: andrew, emaste.

andrew added inline comments.Jan 25 2016, 11:52 AM

lib/libthr/arch/riscv/include/pthread_md.h
64 ↗	(On Diff #12678)	Why `+ 0x10`?

unmagic 0x10, which is TP_OFFSET

br marked an inline comment as done.Jan 25 2016, 2:03 PM

br added inline comments.

lib/libthr/arch/riscv/include/pthread_md.h
65 ↗	(On Diff #12682)	it is TP_OFFSET (architecture specific)

andrew added inline comments.Jan 25 2016, 2:40 PM

lib/libthr/arch/riscv/include/pthread_md.h
65 ↗	(On Diff #12682)	Why is it needed? `rtld-elf` already takes the size of `struct tcb` into account.

br marked an inline comment as done.Jan 25 2016, 3:38 PM

br added inline comments.

lib/libthr/arch/riscv/include/pthread_md.h
65 ↗	(On Diff #12682)	So compiler expects that tp register points to the first static TLS block. In variant I it is located just after struct tcb. We do the same in lib/libc/riscv/gen/_set_tp.c

Closed by commit rS294912: Add pthread MD part for RISC-V. (authored by br). · Explain WhyJan 27 2016, 2:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libthr/

arch/

riscv/

include/

pthread_md.h

92 lines

Diff 12756

View Options

head/lib/libthr/arch/riscv/include/pthread_md.h

libthr for RISC-VClosedPublicActions