pf (t)ftp-proxy: use libpfctl instead of DIOCGETSTATUS
ClosedPublic
Actions

Authored by kp on Aug 30 2023, 12:23 PM.

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG50eccf98b27d: pf (t)ftp-proxy: use libpfctl instead of DIOCGETSTATUS
rGc34ca43649db: pf (t)ftp-proxy: use libpfctl instead of DIOCGETSTATUS
rGddd08375c855: pf (t)ftp-proxy: use libpfctl instead of DIOCGETSTATUS

Summary

Prefer libpfctl functions over direct access to the ioctl whenever
possible. This will allow subsequent removal of DIOCGETSTATUS (in 15) as
there already is an nvlist-based alternative.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Aug 30 2023, 12:23 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 30 2023, 12:23 PM

kp requested review of this revision.Aug 30 2023, 12:23 PM

kp added a child revision: D41648: libpfctl: allow pfctl_free_status(NULL).

same comment as for snmp

Harbormaster completed remote builds in B53338: Diff 126676.Aug 31 2023, 3:32 AM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 31 2023, 8:56 AM

Closed by commit rGddd08375c855: pf (t)ftp-proxy: use libpfctl instead of DIOCGETSTATUS (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGddd08375c855: pf (t)ftp-proxy: use libpfctl instead of DIOCGETSTATUS.

kp added a commit: rGc34ca43649db: pf (t)ftp-proxy: use libpfctl instead of DIOCGETSTATUS.Sep 7 2023, 7:25 PM

kp added a commit: rG50eccf98b27d: pf (t)ftp-proxy: use libpfctl instead of DIOCGETSTATUS.Sep 9 2023, 11:51 AM

Revision Contents
Changeset List

Path

Size

contrib/

pf/

ftp-proxy/

filter.c

9 lines

tftp-proxy/

filter.c

9 lines

Diff 126719

View Options

contrib/pf/ftp-proxy/filter.c