snmp_pf: use libpfctl's pfctl_get_status() rather than DIOCGETSTATUS
ClosedPublic
Actions

Authored by kp on Aug 30 2023, 12:24 PM.

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG1332487c3720: snmp_pf: use libpfctl's pfctl_get_status() rather than DIOCGETSTATUS
rG84983bf36458: snmp_pf: use libpfctl's pfctl_get_status() rather than DIOCGETSTATUS
rG6fbb9fbf7d65: snmp_pf: use libpfctl's pfctl_get_status() rather than DIOCGETSTATUS

Summary

Prefer libpfctl functions over direct access to the ioctl whenever
possible. This will allow subsequent removal of DIOCGETSTATUS (in 15) as
there already is an nvlist-based alternative.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 53341
Build 50232: arc lint + arc unit

Event Timeline

kp created this revision.Aug 30 2023, 12:24 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 30 2023, 12:24 PM

kp requested review of this revision.Aug 30 2023, 12:24 PM

kp added a parent revision: D41649: libpfctl: implement status counter accessor functions.

kp added a child revision: D41651: pf: remove DIOCGETRULE and DIOCGETSTATUS.

i don't think there is anyone to review this, just commit

Harbormaster completed remote builds in B53341: Diff 126679.Aug 31 2023, 3:32 AM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 31 2023, 8:57 AM

Closed by commit rG6fbb9fbf7d65: snmp_pf: use libpfctl's pfctl_get_status() rather than DIOCGETSTATUS (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG6fbb9fbf7d65: snmp_pf: use libpfctl's pfctl_get_status() rather than DIOCGETSTATUS.

kp added a commit: rG84983bf36458: snmp_pf: use libpfctl's pfctl_get_status() rather than DIOCGETSTATUS.Sep 7 2023, 7:25 PM

kp added a commit: rG1332487c3720: snmp_pf: use libpfctl's pfctl_get_status() rather than DIOCGETSTATUS.Sep 9 2023, 11:51 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bsnmpd/

modules/

snmp_pf/

pf_snmp.c

74 lines

Diff 126679

View Options

usr.sbin/bsnmpd/modules/snmp_pf/pf_snmp.c

snmp_pf: use libpfctl's pfctl_get_status() rather than DIOCGETSTATUSClosedPublicActions