Page MenuHomeFreeBSD

clk_fixed: reduce and clarify messages due to missing clk-frequency
ClosedPublic

Authored by karels on Aug 25 2023, 4:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 3:17 PM
Unknown Object (File)
Thu, Oct 24, 3:36 AM
Unknown Object (File)
Wed, Oct 23, 8:51 PM
Unknown Object (File)
Sep 22 2024, 4:29 AM
Unknown Object (File)
Sep 20 2024, 11:27 PM
Unknown Object (File)
Sep 20 2024, 10:53 AM
Unknown Object (File)
Sep 20 2024, 1:00 AM
Unknown Object (File)
Sep 17 2024, 11:14 AM
Subscribers

Details

Summary

The current dts for Raspberry 3B+ and 4B have 2 disabled fixed-clock
nodes which have no clock-frequency value. Such nodes are non-standard.
This results in about 150 messages during autoconfiguration:

clk_fixed2: <Fixed clock> disabled on ofwbus0
clk_fixed2: Cannot FDT parameters.
device_attach: clk_fixed2 attach returned 6

Defensively check for clock-frequency in the probe routine, and if
none, return an error with a more direct error message (1 line per
occurrence, 50 lines total):

clk_fixed2: clock-fixed has no clock-frequency

Based on a patch by manu.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53290
Build 50181: arc lint + arc unit