Page MenuHomeFreeBSD

ps: Complete libxo transition.
ClosedPublic

Authored by yanhaowang on Aug 11 2023, 6:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 8:22 PM
Unknown Object (File)
Wed, Jan 29, 9:22 AM
Unknown Object (File)
Wed, Jan 29, 9:07 AM
Unknown Object (File)
Wed, Jan 29, 5:44 AM
Unknown Object (File)
Tue, Jan 28, 11:48 AM
Unknown Object (File)
Mon, Jan 27, 10:57 PM
Unknown Object (File)
Jan 16 2025, 8:11 PM
Unknown Object (File)
Jan 16 2025, 8:09 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53187
Build 50078: arc lint + arc unit

Event Timeline

  • Remove unnecessary space line.
des requested changes to this revision.Aug 17 2023, 3:26 PM

As a general note (also regarding your other reviews), using EXIT_SUCCESS and EXIT_FAILURE instead of 0 and 1 is a matter of taste, but whichever option you choose should be applied consistently. If the program you're working on has a large number of instances of xo_err(1, ...) or xo_errx(1, ...), you'll have to decide whether to change them all to xo_err(EXIT_FAILURE, ...) or xo_errx(EXIT_FAILURE, ...) or whether to stick to 1 and 0 to reduce the magnitude of the change.

bin/ps/keyword.c
302

EXIT_FAILURE

311

EXIT_FAILURE

356

EXIT_FAILURE

This revision now requires changes to proceed.Aug 17 2023, 3:26 PM
bin/ps/ps.c
1462

There is no need for a cast here.

This revision is now accepted and ready to land.Aug 26 2023, 11:52 PM
This revision was automatically updated to reflect the committed changes.