Page MenuHomeFreeBSD
Differential D41356

vtnet: allow IFF_ALLMULTI to be set without VIRTIO_NET_F_CTRL_RX
ClosedPublic
Actions

Authored by kp on Aug 8 2023, 12:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 11, 3:06 PM
Unknown Object (File)
Fri, Sep 11, 2:11 PM
Unknown Object (File)
Fri, Sep 11, 12:32 PM
Unknown Object (File)
Wed, Sep 9, 9:55 PM
Unknown Object (File)
Wed, Sep 9, 1:30 PM
Unknown Object (File)
Tue, Sep 8, 9:41 PM
Unknown Object (File)
Tue, Sep 8, 1:48 PM
Unknown Object (File)
Tue, Sep 8, 1:36 PM
View All Files
Subscribers
freebsd_igalic.co
imp

Details

Reviewers
None
Group Reviewers
pfsense
network
Commits
rG580cadd6a5f0: vtnet: allow IFF_ALLMULTI to be set without VIRTIO_NET_F_CTRL_RX
Summary

If the host doesn't announce VIRTIO_NET_F_CTRL_RX we cannot disable all
multicast traffic. Previously we'd refuse to set the IFF_ALLMULTI flag,
which is the exact opposite of what is actually happening.

This broke things such as igmpproxy.

See also: https://redmine.pfsense.org/issues/14301
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53011
Build 49902: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
dev/
virtio/
network/
7 lines

Diff 125696

View Options

sys/dev/virtio/network/if_vtnet.c

Loading...