Differential D5021

compiler_rt changes for RISC-V
ClosedPublic
Actions

Authored by br on Jan 21 2016, 4:25 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 7, 7:23 PM

	Unknown Object (File)
	Sat, Dec 7, 7:23 PM

	Unknown Object (File)
	Sat, Dec 7, 7:07 PM

	Unknown Object (File)
	Sun, Dec 1, 9:31 PM

	Unknown Object (File)
	Sun, Dec 1, 5:26 PM

	Unknown Object (File)
	Mon, Nov 25, 1:54 PM

	Unknown Object (File)
	Nov 24 2024, 2:18 PM

	Unknown Object (File)
	Nov 24 2024, 1:15 AM

Subscribers

None

Details

Reviewers

emaste
andrew

Commits

rS294577: Add support for RISC-V ISA.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

br updated this revision to Diff 12560.Jan 21 2016, 4:25 PM

br retitled this revision from to compiler_rt changes for RISC-V.

br updated this object.

br edited the test plan for this revision. (Show Details)

br added reviewers: andrew, emaste.

emaste added inline comments.Jan 21 2016, 5:28 PM

contrib/compiler-rt/lib/builtins/int_lib.h
77–81	The comment doesn't match the #if condition now. Presumably it's any version of GCC, and targeting an arch that does not have dedicated bit counting instructions. We'll also need to push this upstream.
contrib/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.h
80–81	Do you know if these values will apply on Linux as well?
contrib/compiler-rt/lib/sanitizer_common/sanitizer_posix.cc
98	RISC-V comment?

br added inline comments.Jan 21 2016, 5:44 PM

contrib/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.h
80–81	They actually do that: const unsigned struct_kernel_stat_sz = 128; const unsigned struct_kernel_stat64_sz = 128;

synced with Linux

br marked 3 inline comments as done.Jan 21 2016, 6:23 PM

context added

extra change removed

emaste accepted this revision.Jan 22 2016, 4:46 PM

emaste edited edge metadata.

This revision is now accepted and ready to land.Jan 22 2016, 4:46 PM

Mark TODO

This revision now requires review to proceed.Jan 22 2016, 4:55 PM

emaste accepted this revision.Jan 22 2016, 4:58 PM

emaste edited edge metadata.

This revision is now accepted and ready to land.Jan 22 2016, 4:58 PM

Closed by commit rS294577: Add support for RISC-V ISA. (authored by br). · Explain WhyJan 22 2016, 4:59 PM

This revision was automatically updated to reflect the committed changes.

luis_luismarques.eu mentioned this in D21684: Fix compiler_rt definition for RISC-V.Sep 17 2019, 10:30 AM

emaste mentioned this in rS352792: compiler-rt: correct RISC-V struct_kernel_stat64_sz.Sep 27 2019, 1:14 PM

dim mentioned this in rS356460: Merge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp.Jan 7 2020, 6:13 PM

dim mentioned this in rS360658: Merge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp.May 5 2020, 1:05 PM

Revision Contents
Changeset List

Path

Size

contrib/

compiler-rt/

lib/

builtins/

2 lines

sanitizer_common/

sanitizer_platform_limits_posix.h

5 lines

sanitizer_posix.cc

2 lines

sanitizer_stacktrace.h

6 lines

Diff 12560

contrib/compiler-rt/lib/builtins/int_lib.h

Loading...

contrib/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.h

Loading...

contrib/compiler-rt/lib/sanitizer_common/sanitizer_posix.cc

Loading...

contrib/compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.h

Loading...