KERN_PROC_VM_LAYOUT sysctl: fix bug in 32-bit-compatible path
ClosedPublic
Actions

Authored by • karels on Jul 7 2023, 12:06 PM.

Tags

None

Referenced Files

	F166797171: D40908.diff
	Sun, Aug 16, 6:40 PM

	F166797165: D40908.diff
	Sun, Aug 16, 6:40 PM

	Unknown Object (File)
	Mon, Aug 10, 5:35 PM

	Unknown Object (File)
	Mon, Aug 10, 10:19 AM

	Unknown Object (File)
	Sat, Aug 8, 6:51 PM

	Unknown Object (File)
	Thu, Aug 6, 1:18 AM

	Unknown Object (File)
	Wed, Aug 5, 5:39 PM

	Unknown Object (File)
	Wed, Jul 22, 8:09 PM

View All Files

Subscribers

imp

Details

Reviewers

markj

Commits

rGbe30fd3ab2e8: KERN_PROC_VM_LAYOUT sysctl: fix bug in 32-bit-compatible path

Summary

vmspace_free() is called redundantly in the 32-bit-compatible
path in sysctl_kern_proc_vm_layout(), causing a premature free
(possibly for the current address space). Remove the extra call.

PR: 272401
Reported by: marklmi at yahoo.com

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 52476
Build 49367: arc lint + arc unit

Event Timeline

• karels created this revision.Jul 7 2023, 12:06 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 7 2023, 12:06 PM

• karels requested review of this revision.Jul 7 2023, 12:06 PM

Harbormaster completed remote builds in B52476: Diff 124278.Jul 7 2023, 12:06 PM

markj accepted this revision.Jul 7 2023, 1:06 PM

This revision is now accepted and ready to land.Jul 7 2023, 1:06 PM

Closed by commit rGbe30fd3ab2e8: KERN_PROC_VM_LAYOUT sysctl: fix bug in 32-bit-compatible path (authored by • karels). · Explain WhyJul 7 2023, 1:41 PM

This revision was automatically updated to reflect the committed changes.

• karels added a commit: rGbe30fd3ab2e8: KERN_PROC_VM_LAYOUT sysctl: fix bug in 32-bit-compatible path.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_proc.c

1 line

Diff 124278

View Options

KERN_PROC_VM_LAYOUT sysctl: fix bug in 32-bit-compatible pathClosedPublicActions