Switch from FD_SETSIZE to getdtablesize().
ClosedPublic
Actions

Authored by araujo on Jan 18 2016, 2:20 AM.

Details

Reviewers

• rodrigc
bapt

Commits

rS294543: Switch from FD_SETSIZE to getdtablesize(2) as it can make the FD to be

Summary

@rodrigc requested to switch to getdtablesize() as it will be more close with
what was implemented on OpenBSD. I have no objection with it as it has a good
side and the FD can be tunable.

However, it will be slower than FD_SETSIZE as it needs to calloc more than 1024.
Not a big deal to be honest.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2159
Build 2168: arc lint + arc unit

Event Timeline

araujo updated this revision to Diff 12396.Jan 18 2016, 2:20 AM

araujo retitled this revision from to Switch from FD_SETSIZE to getdtablesize()..

araujo updated this object.

araujo edited the test plan for this revision. (Show Details)

araujo added reviewers: • rodrigc, bapt.

araujo added a subscriber: • rodrigc.

Herald added a subscriber: imp. · View Herald TranscriptJan 18 2016, 2:20 AM

• rodrigc accepted this revision.Jan 22 2016, 2:33 AM

• rodrigc edited edge metadata.

This revision is now accepted and ready to land.Jan 22 2016, 2:33 AM

Closed by commit rS294543: Switch from FD_SETSIZE to getdtablesize(2) as it can make the FD to be (authored by araujo). · Explain WhyJan 22 2016, 3:02 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.sbin/

ypldap/

yp.c

15 lines

Diff 12396

View Options

Switch from FD_SETSIZE to getdtablesize().ClosedPublicActions