Differential D40726

Add quotes to zzz.sh and replace legacy backticks with $()
ClosedPublic
Actions

Authored by bcr on Jun 23 2023, 4:55 PM.

Details

Reviewers

imp

Commits

rG7776cec946fb: Add quotes around variables and replace backticks with $()

Summary

This patch does the following:

Replaces legacy backticks with $()
Quote strings to prevent word splitting

Test Plan

The changes should not affect the code execution, but I found no tests for zzz that I could run.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

bcr created this revision.Jun 23 2023, 4:55 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 23 2023, 4:55 PM

bcr requested review of this revision.Jun 23 2023, 4:55 PM

imp added inline comments.Jun 26 2023, 3:15 PM

usr.sbin/zzz/zzz.sh
21	You can kill the space before the ).

Thanks for the feedback. I removed the extra whitespace at the line you mentioned and in another instance further down.

bcr marked an inline comment as done.Jun 27 2023, 7:03 AM

I'm bothered by the pre existing echo grep pair.
But these cleanups do make the code marginally better...

This revision is now accepted and ready to land.Jun 27 2023, 12:55 PM

Closed by commit rG7776cec946fb: Add quotes around variables and replace backticks with $() (authored by bcr). · Explain WhyJun 28 2023, 4:53 PM

This revision was automatically updated to reflect the committed changes.

bcr added a commit: rG7776cec946fb: Add quotes around variables and replace backticks with $().

Revision Contents
Changeset List

Path

Size

usr.sbin/

zzz/

zzz.sh

10 lines

Diff 123808

View Options

Add quotes to zzz.sh and replace legacy backticks with $()ClosedPublicActions