Differential D40714

support for rockchip rk3308 cru
Needs RevisionPublic
Actions

Authored by titus_edc.ro on Jun 22 2023, 10:11 AM.

Tags

None

Referenced Files

	F153444752: D40714.id123649.diff
	Tue, Apr 21, 5:23 AM

	Unknown Object (File)
	Thu, Apr 16, 9:21 PM

	Unknown Object (File)
	Wed, Apr 15, 11:57 AM

	Unknown Object (File)
	Mar 18 2026, 11:58 AM

	Unknown Object (File)
	Jan 25 2026, 5:39 AM

	Unknown Object (File)
	Jan 20 2026, 9:23 AM

	Unknown Object (File)
	Dec 20 2025, 7:28 PM

	Unknown Object (File)
	Nov 27 2025, 4:33 AM

View All 83 Files

Subscribers

Details

Reviewers

andrew
manu

Group Reviewers

Summary

file generated mostly with a set of cpp macros to convert from linux macros to freebsd
macros were "validated" against rk3568_cru.c

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

titus_edc.ro created this revision.Jun 22 2023, 10:11 AM

Herald added a reviewer: andrew. · View Herald TranscriptJun 22 2023, 10:11 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: andrew, emaste. · View Herald Transcript

titus_edc.ro requested review of this revision.Jun 22 2023, 10:11 AM

andrew removed a subscriber: freebsd-arm-list.Jun 22 2023, 10:35 AM

manu requested changes to this revision.Jun 22 2023, 1:13 PM

manu added inline comments.

sys/arm64/rockchip/clk/rk3308_cru.c
46	#include <cdt-bindings/clock/rk3308-cru.h> should be enough.
116	Why defining this when we have macros in rc_cru.h ? Looks like you've copied that rk3568_cru.c which alredy redefines this (and also have bad clock topology, I've raised this already when this was commited).

This revision now requires changes to proceed.Jun 22 2023, 1:13 PM

titus_edc.ro added inline comments.Jun 22 2023, 2:38 PM

sys/arm64/rockchip/clk/rk3308_cru.c
116	yes, rk3568_cru.c was the "template", had no idea that was bad (also was the closest to what linux driver src looked like so it was easiest to adapt)

Revision Contents
Changeset List

Path

Size

sys/

arm64/

conf/

1 line

rockchip/

clk/

749 lines

conf/

1 line

Diff 123649

sys/arm64/conf/std.rockchip

Loading...

sys/arm64/rockchip/clk/rk3308_cru.c

Loading...

sys/conf/files.arm64

Loading...