Paths

Table of Contentst

Differential D40218

timerfd: Add manual page
ClosedPublic
Actions

Authored by jfree on May 22 2023, 10:02 PM.

Tags

Referenced Files

	F84308310: D40218.id126480.diff
	Wed, May 22, 3:26 AM

	F84302284: D40218.id126480.diff
	Wed, May 22, 1:16 AM

	Unknown Object (File)
	Tue, May 21, 10:01 AM

	Unknown Object (File)
	Mon, May 20, 6:37 PM

	Unknown Object (File)
	Mon, May 20, 6:37 PM

	Unknown Object (File)
	Mon, May 20, 6:36 PM

	Unknown Object (File)
	Mon, May 20, 6:36 PM

	Unknown Object (File)
	Mon, May 20, 1:55 PM

View All 65 Files

Subscribers

Details

Reviewers

gbe
grahamperrin
imp

Commits

rG8544651dc509: timerfd: Add manual page.

Summary

This manual page accompanies the timerfd system calls.

https://reviews.freebsd.org/D38459

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

jfree created this revision.May 22 2023, 10:02 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 22 2023, 10:02 PM

jfree requested review of this revision.May 22 2023, 10:02 PM

Just a little style for the mail addresses in the HISTORY section, otherwise LGTM. Can't speak for the technical details.

lib/libc/sys/timerfd.2
328	I would add an '.An -nosplit' after .Sh HISTORY.
332	On a separate line .An Dmitry Chagin Aq Mt dchagin@FreeBSD.org
334	On a separaate line .An Jake Freeland Aq Mt jfree@FreeBSD.org

Fix formatting in HISTORY section thanks to @gbe.

grahamperrin requested changes to this revision.Jun 29 2023, 3:47 AM

grahamperrin added a subscriber: grahamperrin.

grahamperrin added inline comments.

lib/libc/sys/timerfd.2
166	Might Normally or Typically be better? (Because regularity can be time-related, i.e. "like clockwork".)
235
273
287

This revision now requires changes to proceed.Jun 29 2023, 3:47 AM

Address @grahamperrin's comments.

Looks good to my eye. Looks like all the comments have been addressed.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 24 2023, 8:31 PM

Closed by commit rG8544651dc509: timerfd: Add manual page. (authored by jfree, committed by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG8544651dc509: timerfd: Add manual page..

Revision Contents
Changeset List

Path

Size

lib/

libc/

sys/

4 lines

335 lines

Diff 122252

lib/libc/sys/Makefile.inc

Loading...

lib/libc/sys/timerfd.2

Loading...