riscv: rework CPU identification [7/7]
ClosedPublic
Actions

Authored by mhorne on May 9 2023, 5:16 PM.

Details

Reviewers

markj
jrtc27

Group Reviewers

riscv

Commits

rGad1ed7742f0e: riscv: Print less CPU info
rG940e6d36de1e: riscv: Print less CPU info

Summary

Change the reporting strategy to more closely follow what arm64
implements:

Always print the one-line CPU summary when a core comes online
Only print the additional fields (e.g. ISA) when they differ from the CPU before it

In the common case of identical CPUs this results in informative but
non-repetitive output.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 51402
Build 48293: arc lint + arc unit

Event Timeline

mhorne created this revision.May 9 2023, 5:16 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 9 2023, 5:16 PM

mhorne requested review of this revision.May 9 2023, 5:16 PM

Harbormaster completed remote builds in B51402: Diff 121763.May 9 2023, 5:16 PM

mhorne added a parent revision: D39814: riscv: rework CPU identification [6/6].May 9 2023, 5:16 PM

markj accepted this revision.May 11 2023, 3:35 PM

markj added inline comments.

sys/riscv/riscv/identcpu.c
455	Indentation looks wrong here.

This revision is now accepted and ready to land.May 11 2023, 3:35 PM

Closed by commit rG940e6d36de1e: riscv: Print less CPU info (authored by mhorne). · Explain WhyMay 23 2023, 1:24 PM

This revision was automatically updated to reflect the committed changes.

mhorne marked an inline comment as done.

mhorne added a commit: rG940e6d36de1e: riscv: Print less CPU info.

mhorne added a commit: rGad1ed7742f0e: riscv: Print less CPU info.Jun 12 2023, 2:29 PM

Revision Contents
Changeset List

Path

Size

sys/

riscv/

identcpu.c

24 lines

Diff 121763

View Options

sys/riscv/riscv/identcpu.c

riscv: rework CPU identification [7/7]ClosedPublicActions