Page MenuHomeFreeBSD
Differential D39946

dpaa2: Simplify addresses translation with PHYS_TO_DMAP
ClosedPublic
Actions

Authored by dsl on May 3 2023, 10:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 2:16 PM
Unknown Object (File)
Fri, Jan 24, 11:49 AM
Unknown Object (File)
Sat, Jan 11, 2:49 AM
Unknown Object (File)
Dec 31 2024, 10:49 AM
Unknown Object (File)
Dec 14 2024, 5:07 PM
Unknown Object (File)
Dec 9 2024, 3:31 AM
Unknown Object (File)
Nov 3 2024, 5:13 AM
Unknown Object (File)
Nov 3 2024, 5:13 AM
View All 97 Files
Subscribers
dan.kotowski_a9development.com
imp

Details

Reviewers
bz
mhorne
Commits
rG718bdb6a71ba: dpaa2: Simplify addresses translation with PHYS_TO_DMAP
Summary

All frames will have their struct dpaa2_fa annotations populated
to find correct buffers based on the physical addresses stored in
the frames descriptors. It helps to avoid carrying different indexes
in the MSBs of the physical addresses and removes an artifical limit
to the number of Rx/Tx buffers/descriptors.

freebsd-arm discussion: https://lists.freebsd.org/archives/freebsd-arm/2023-April/002478.html

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dsl created this revision.May 3 2023, 10:25 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 3 2023, 10:25 AM
dsl requested review of this revision.May 3 2023, 10:25 AM
dsl updated this revision to Diff 121465.May 3 2023, 10:32 AM

I've removed a [DMAP_MIN_PHYSADDR,DMAP_MAX_PHYSADDR] range limit for DMA tags as @mhorne explained. Initially, I thought that it's a requirement to calculate KVA by PHYS_TO_DMAP properly.

dan.kotowski_a9development.com added a subscriber: dan.kotowski_a9development.com.May 5 2023, 5:17 AM
bz accepted this revision.May 5 2023, 10:08 AM

All the changes I pointed out seem of more cosmetic nature. I'll leave it up to you if you want to do them.

sys/dev/dpaa2/dpaa2_ni.c
3356

Do we need a runtime check in all cases for this or could this be a KASSERT as well so it'll not be done in non-debug code?

3472

KASSERT like above?

3510

And again here.

sys/dev/dpaa2/dpaa2_swp.h
355

You could add a CTASSERT if this needs to be enforced hard.

This revision is now accepted and ready to land.May 5 2023, 10:08 AM
bz added a comment.May 5 2023, 12:49 PM

And if @mhorne is okay as well, feel free to commit.
Approved by: bz (mentor)

dsl added inline comments.May 8 2023, 11:14 AM
sys/dev/dpaa2/dpaa2_ni.c
3356

It can be converted to KASSERT, but I haven't heard from Matt about https://github.com/mcusim/freebsd-src/issues/8 for sometime already. Let me keep this check for now and we'll return to it in future reviews as I'm re-working Rx/Tx routines at the moment.

3472

Answered above

dsl updated this revision to Diff 121673.May 8 2023, 11:28 AM

I've added CTASSERT checks to all of the types which sizes are fixed or shouldn't exceed limits enforced by DPAA2 firmware.

This revision now requires review to proceed.May 8 2023, 11:28 AM
mhorne added a comment.May 8 2023, 1:19 PM

Makes sense to me, but obviously I do not understand the driver at large. The usage of PHYS_TO_DMAP() is valid.

sys/dev/dpaa2/dpaa2_ni.c
2031–2036

So, this was an artificial (software) limit so that you could use the high bits for encoding indices?

3351
sys/dev/dpaa2/dpaa2_swp.h
218–245

This is a strange use of an enum rather than #define.

mhorne accepted this revision.May 8 2023, 1:24 PM
This revision is now accepted and ready to land.May 8 2023, 1:24 PM
dsl added inline comments.May 9 2023, 8:37 AM
sys/dev/dpaa2/dpaa2_ni.c
2031–2036

Not actually. According to the LX2160A DPAA2 Low-Level Hardware Reference Manual, buffer address in the frame descriptor is 49-bit long, but bits 49-63 can be used as a software token to assist in the physical to virtual address translation which isn't needed anymore.

bz added a comment.May 9 2023, 10:23 AM

Great. I am doing a rebuild now.

sys/dev/dpaa2/dpaa2_ni.c
3356

ACK.

dsl updated this revision to Diff 121732.May 9 2023, 10:32 AM

I've replaced anonymous enum with macro definitions for sizes.

This revision now requires review to proceed.May 9 2023, 10:32 AM
dsl added a comment.May 11 2023, 9:33 AM

@bz, Can I commit?

This revision was not accepted when it landed; it landed in state Needs Review.May 11 2023, 3:46 PM
Closed by commit rG718bdb6a71ba: dpaa2: Simplify addresses translation with PHYS_TO_DMAP (authored by dsl). · Explain Why
This revision was automatically updated to reflect the committed changes.
dsl added a commit: rG718bdb6a71ba: dpaa2: Simplify addresses translation with PHYS_TO_DMAP.

Revision Contents
Changeset List

PathSize
sys/
dev/
dpaa2/
2 lines
210 lines
75 lines
2 lines

Diff 121673

View Options

sys/dev/dpaa2/dpaa2_ni.h

Loading...
View Options

sys/dev/dpaa2/dpaa2_ni.c

Loading...
View Options

sys/dev/dpaa2/dpaa2_swp.h

Loading...
View Options

sys/dev/dpaa2/dpaa2_types.h

Loading...